fix: normalize Conda environment cache keys (Fixes #488) - #490
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
July 27, 2026 02:45
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (Linux) ➖
Legend
|
Test Coverage Report (Windows)
Coverage increased! Great work! |
Performance Report (macOS)
Legend
|
Performance Report (Windows) ➖
Legend
|
Copilot started reviewing on behalf of
Karthik Nadig (karthiknadig)
July 27, 2026 02:45
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates PET’s Conda locator to normalize the keys used by the shared Conda environment metadata cache, improving cross-refresh reuse (especially on Windows where the same path can appear with different casing/separators) while keeping the fingerprint-based invalidation behavior introduced in #487.
Changes:
- Normalize Conda environment metadata cache keys (
norm_case) for cache lookup, insertion, and removal. - Use normalized prefixes when pruning stale cache entries after discovery refresh.
Show a summary per file
| File | Description |
|---|---|
| crates/pet-conda/src/lib.rs | Normalizes Conda environment-info cache keys and uses normalized active prefixes when pruning stale cache entries. |
Review details
Comments suppressed due to low confidence (1)
crates/pet-conda/src/lib.rs:185
- Because the cache key is now normalized, a lookup for the same on-disk env using a differently-cased / differently-formatted path can return cached details whose
environment.prefixreflects the first path that populated the cache, not thepathrequested in this call. Callers (e.g.try_from/find) assume the returned environment details correspond to the input prefix, and this mismatch can lead to inconsistent reported prefixes and duplicate internal entries keyed by one path while carrying another in the value.
Consider patching the cached result before returning so environment.prefix always matches the requested path.
.expect("conda environment info cache lock poisoned")
.get(&cache_key)
.filter(|cached| &cached.fingerprint == fingerprint)
{
return Some(cached.details.clone());
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Add Windows regression coverage for equivalent separator styles while ensuring cache hits return the caller's requested prefix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Karthik Nadig (karthiknadig)
July 27, 2026 02:52
View session
Karthik Nadig (karthiknadig)
changed the title
Dmitriy Vasyura (dmitrivMS)
approved these changes
Jul 27, 2026
This was referenced Aug 5, 2026
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
Aug 5, 2026
## Summary - add a PET-wide Rust coding skill alongside locator-specific guidance - capture path identity/cache, Unicode-safe parsing, hot-path I/O/allocation, and cross-platform rules - require tests to prove claimed read-count, cache-hit, and event-count invariants - wire the recurring checks into the Reviewer agent for every Rust change ## Review retrospective Recent feedback clustered around: - normalized cache keys and caller-facing path preservation (#487, #490) - Unicode-safe byte indexing and ASCII format handling (#493) - proving optimization scope and read counts (#493) - duplicate side effects and precise pattern semantics (#495) - workflow assignment/merge postconditions, already addressed in #486 Fixes #496 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo test -p pet-conda environment_info_cache_.\scripts\rust-precommit.ps1Fixes #488