chore: harden maintainer completion workflow (Fixes #485) - #486
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
July 24, 2026 20:52
Performance Report (Linux) ➖
Legend
|
Performance Report (macOS)
Legend
|
Test Coverage Report (Windows)
Coverage unchanged. |
Performance Report (Windows) ✅
Legend
|
Test Coverage Report (Linux)
Coverage unchanged. |
Copilot started reviewing on behalf of
Karthik Nadig (karthiknadig)
July 24, 2026 20:52
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Maintainer agent playbook to harden PR completion (review request fallback, quality-gate checks, merge verification, and optional autonomous continuation) so maintainers don’t merge based solely on command exit codes or green CI status.
Changes:
- Document a GitHub API fallback for requesting Copilot review and require verifying the reviewer assignment.
- Add a required “quality snapshot” inspection step (performance, coverage, analysis) before merge.
- Require verifying merge/auto-merge postconditions and outline continuous maintenance behavior when explicitly requested.
Show a summary per file
| File | Description |
|---|---|
| .github/agents/Maintainer.agent.md | Adds stricter maintainer workflow requirements: reviewer-request fallback + verification, quality snapshot inspection, merge postcondition verification, and continuous maintenance mode guidance. |
Review details
Comments suppressed due to low confidence (1)
.github/agents/Maintainer.agent.md:242
- The text requires the verification output to include
Copilot, but the API output you’re printing is.users[].login(e.g.,copilot-pull-request-reviewer[bot]). This mismatch can cause the workflow to block even when the reviewer is assigned.
The verification output must include `Copilot` before entering the review polling loop.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Low
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Martin Aeschlimann (aeschli)
approved these changes
Jul 24, 2026
Copilot started reviewing on behalf of
Karthik Nadig (karthiknadig)
July 24, 2026 21:00
View session
Contributor
There was a problem hiding this comment.
Review details
Comments suppressed due to low confidence (2)
.github/agents/Maintainer.agent.md:239
- The jq verification is filtering for
.login == "Copilot", but the reviewer being requested above iscopilot-pull-request-reviewer[bot]. This will typically return no output, so the assignment verification step won’t work as intended.
gh api repos/OWNER/REPO/pulls/N/requested_reviewers --jq '.users[] | select(.login == "Copilot") | .login'
.github/agents/Maintainer.agent.md:242
- This verification requirement says the output must include
Copilot, but the preceding command requestscopilot-pull-request-reviewer[bot]. The required output string should match the actual reviewer login being checked.
The verification output must include `Copilot` before entering the review polling loop.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Low
This was referenced Aug 5, 2026
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
Aug 5, 2026
## Summary - add a PET-wide Rust coding skill alongside locator-specific guidance - capture path identity/cache, Unicode-safe parsing, hot-path I/O/allocation, and cross-platform rules - require tests to prove claimed read-count, cache-hit, and event-count invariants - wire the recurring checks into the Reviewer agent for every Rust change ## Review retrospective Recent feedback clustered around: - normalized cache keys and caller-facing path preservation (#487, #490) - Unicode-safe byte indexing and ASCII format handling (#493) - proving optimization scope and read counts (#493) - duplicate side effects and precise pattern semantics (#495) - workflow assignment/merge postconditions, already addressed in #486 Fixes #496 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #485