Skip to content

Fix/managed exports japan timezone - #2236

Merged
Roland Krummenacher (RolandKrummenacher) merged 3 commits into
microsoft:devfrom
TakumiSeo:fix/managed-exports-japan-timezone
Aug 5, 2026
Merged

Fix/managed exports japan timezone#2236
Roland Krummenacher (RolandKrummenacher) merged 3 commits into
microsoft:devfrom
TakumiSeo:fix/managed-exports-japan-timezone

Conversation

@TakumiSeo

Copy link
Copy Markdown
Contributor

Changes the managed exports time zone mapping for Japan from Japan Standard Time to Tokyo Standard Time.

Azure Cost Management managed exports expect Tokyo Standard Time for the Data Factory schedule trigger. Using Japan Standard Time causes trigger validation to fail.

This supersedes #2219, which was accidentally opened from microsoft:main and did not include the intended file changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the managed exports time zone mapping for Japan to use the Windows time zone ID expected by Azure Data Factory schedule triggers, preventing trigger validation failures when deploying managed exports.

Changes:

  • Switch japaneast and japanwest from Japan Standard Time to Tokyo Standard Time in the Managed Exports time zone mapping.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified beyond the diff: I extracted every timezone ID from timeZones.bicep at this PR's head and validated all 13 distinct IDs case-sensitively against the Windows timezone registry (Get-TimeZone -ListAvailable), which is what the Data Factory schedule trigger validates against. Japan Standard Time was the only invalid ID in the file — it's the IANA-style display name, not a Windows ID — and Tokyo Standard Time is the correct replacement. All other mappings (Korea, China, Singapore, India, AUS Eastern, etc.) check out, so no sibling entries have the same bug. LGTM, thanks for the fix!

@flanakin Michael Flanakin (flanakin) added this to the v15 milestone Aug 5, 2026
Roland Krummenacher (RolandKrummenacher) pushed a commit that referenced this pull request Aug 5, 2026
…loy templates

The compiled templates in docs/deploy are regenerated at release time and
lagged the src fixes: finops-hub-latest.json and finops-hub-14.0.json still
mapped Japan regions to the display name 'Japan Standard Time', and
finops-hub-preview.json shipped a whole set of pre-fix display names
(Australian Eastern/Brasil/Central European/Greenwich Mean) that fail ADF
trigger activation. Surgically corrects the mapping values to the Windows
time zone IDs matching the current src mapping (northeurope goes to
'GMT Standard Time' per src, not W. Europe).

Extends HubsAdfTriggerTimeZones.Tests.ps1 to also validate the mappings in
finops-hub-latest.json and finops-hub-preview.json so shipped artifacts
can no longer drift invalid, and adds those paths to the Pester workflow
triggers. Raised in the PR #2236 review discussion.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@RolandKrummenacher
Roland Krummenacher (RolandKrummenacher) merged commit 2c7ce26 into microsoft:dev Aug 5, 2026
23 of 29 checks passed
@microsoft-github-policy-service

Copy link
Copy Markdown

@all-contributors please add @TakumiSeo for code

@allcontributors

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service[bot]

I've put up a pull request to add TakuSe (@TakumiSeo)! 🎉

@flanakin

Copy link
Copy Markdown
Collaborator

Fix looks correct — verified Tokyo Standard Time is the right Windows time zone ID for Asia/Tokyo (there is no valid Windows ID called "Japan Standard Time"), matching the same bug class fixed for USGov regions in #2087.

One should-fix: please add a changelog entry under ## UnreleasedFinOps hubs vNext → Fixed, consistent with the precedent set by #2087.

Bonus question (not necessarily for this PR): is there a way to write a test that validates this Azure-region → Windows-timezone mapping — ideally with a completeness check (every current Azure region has an entry, every value is a real Windows time zone ID)? We keep getting one-off PRs/issues for individual regions here; I would love to catch the whole class automatically instead. Might be more of a v16 tracking issue than something to scope into this PR — curious if there is a reasonably cheap way to do it (e.g., validate against Get-TimeZone -ListAvailable or the CLDR Windows↔IANA mapping in a Pester test) before deciding where it belongs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants