Fix/managed exports japan timezone - #2236
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the managed exports time zone mapping for Japan to use the Windows time zone ID expected by Azure Data Factory schedule triggers, preventing trigger validation failures when deploying managed exports.
Changes:
- Switch
japaneastandjapanwestfromJapan Standard TimetoTokyo Standard Timein the Managed Exports time zone mapping.
Roland Krummenacher (RolandKrummenacher)
left a comment
There was a problem hiding this comment.
Verified beyond the diff: I extracted every timezone ID from timeZones.bicep at this PR's head and validated all 13 distinct IDs case-sensitively against the Windows timezone registry (Get-TimeZone -ListAvailable), which is what the Data Factory schedule trigger validates against. Japan Standard Time was the only invalid ID in the file — it's the IANA-style display name, not a Windows ID — and Tokyo Standard Time is the correct replacement. All other mappings (Korea, China, Singapore, India, AUS Eastern, etc.) check out, so no sibling entries have the same bug. LGTM, thanks for the fix!
…loy templates The compiled templates in docs/deploy are regenerated at release time and lagged the src fixes: finops-hub-latest.json and finops-hub-14.0.json still mapped Japan regions to the display name 'Japan Standard Time', and finops-hub-preview.json shipped a whole set of pre-fix display names (Australian Eastern/Brasil/Central European/Greenwich Mean) that fail ADF trigger activation. Surgically corrects the mapping values to the Windows time zone IDs matching the current src mapping (northeurope goes to 'GMT Standard Time' per src, not W. Europe). Extends HubsAdfTriggerTimeZones.Tests.ps1 to also validate the mappings in finops-hub-latest.json and finops-hub-preview.json so shipped artifacts can no longer drift invalid, and adds those paths to the Pester workflow triggers. Raised in the PR #2236 review discussion. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2c7ce26
into
microsoft:dev
|
@all-contributors please add @TakumiSeo for code |
|
@microsoft-github-policy-service[bot] I've put up a pull request to add TakuSe (@TakumiSeo)! 🎉 |
|
Fix looks correct — verified One should-fix: please add a changelog entry under Bonus question (not necessarily for this PR): is there a way to write a test that validates this Azure-region → Windows-timezone mapping — ideally with a completeness check (every current Azure region has an entry, every value is a real Windows time zone ID)? We keep getting one-off PRs/issues for individual regions here; I would love to catch the whole class automatically instead. Might be more of a v16 tracking issue than something to scope into this PR — curious if there is a reasonably cheap way to do it (e.g., validate against |
Changes the managed exports time zone mapping for Japan from
Japan Standard TimetoTokyo Standard Time.Azure Cost Management managed exports expect
Tokyo Standard Timefor the Data Factory schedule trigger. UsingJapan Standard Timecauses trigger validation to fail.This supersedes #2219, which was accidentally opened from
microsoft:mainand did not include the intended file changes.