Skip to content

Update SPIRV-Tools to 1c336172 #8738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Damyan Pepper (damyanp) merged 2 commits into from
Aug 6, 2026
+9 −1
Merged

Update SPIRV-Tools to 1c336172 #8738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8725f5c
Update SPIRV-Tools to 1c336172
damyanp Aug 6, 2026
dd95755
XFAIL resource-heap-ext-texture
damyanp Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ line upon naming the release. Refer to previous for appropriate section names.
- Fixed derivative operations being moved into divergent control flow, which
could produce incorrect results
[#8001](https://github.com/microsoft/DirectXShaderCompiler/issues/8001).
- SPIR-V: Fixed an invalid `OpSelect` being generated when optimizing for
SPIR-V 1.3 and earlier
[#8603](https://github.com/microsoft/DirectXShaderCompiler/issues/8603).

#### HLSL Language

Expand Down
2 changes: 1 addition & 1 deletion external/SPIRV-Tools
Open in desktop
Submodule SPIRV-Tools updated 58 files
+6 −6 .github/workflows/autoroll.yml
+2 −2 .github/workflows/bazel.yml
+1 −1 .github/workflows/ios.yml
+1 −1 .github/workflows/scorecard.yml
+1 −0 Android.mk
+1 −0 BUILD.gn
+3 −3 DEPS
+20 −2 include/spirv-tools/libspirv.h
+22 −0 include/spirv-tools/libspirv.hpp
+1 −0 source/CMakeLists.txt
+23 −8 source/link/linker.cpp
+5 −3 source/opt/const_folding_rules.cpp
+5 −0 source/opt/dominator_analysis.h
+19 −0 source/opt/dominator_tree.cpp
+3 −0 source/opt/dominator_tree.h
+107 −7 source/opt/folding_rules.cpp
+50 −3 source/opt/ir_context.cpp
+8 −2 source/opt/strip_debug_info_pass.cpp
+13 −0 source/opt/struct_cfg_analysis.cpp
+11 −0 source/opt/struct_cfg_analysis.h
+27 −0 source/spirv_validator_options.cpp
+10 −0 source/spirv_validator_options.h
+10 −0 source/util/bit_vector.cpp
+4 −0 source/util/bit_vector.h
+9 −0 source/util/timer.h
+1 −0 source/val/validate.cpp
+2 −0 source/val/validate.h
+1 −0 source/val/validate_cfg.cpp
+12 −6 source/val/validate_conversion.cpp
+5 −1,210 source/val/validate_decorations.cpp
+1,135 −0 source/val/validate_explicit_layout.cpp
+41 −0 source/val/validate_extensions.cpp
+55 −6 source/val/validate_image.cpp
+0 −2 source/val/validate_invalid_type.cpp
+20 −10 source/val/validate_memory.cpp
+19 −2 source/val/validate_scopes.cpp
+52 −4 source/val/validation_state.cpp
+33 −0 test/link/matching_imports_to_exports_test.cpp
+73 −0 test/opt/eliminate_dead_functions_test.cpp
+300 −0 test/opt/fold_test.cpp
+188 −0 test/opt/ir_context_test.cpp
+2 −0 test/opt/remove_unused_interface_variables_test.cpp
+87 −0 test/opt/simplification_test.cpp
+56 −0 test/opt/strip_debug_info_test.cpp
+1 −0 test/val/CMakeLists.txt
+62 −0 test/val/val_barriers_test.cpp
+97 −6 test/val/val_conversion_test.cpp
+4,311 −8,892 test/val/val_decoration_test.cpp
+5,774 −0 test/val/val_explicit_layout_test.cpp
+58 −5 test/val/val_extension_spv_ext_descriptor_heap.cpp
+46 −0 test/val/val_extension_spv_intel_arbitrary_precision_integers_test.cpp
+26 −3 test/val/val_extension_spv_khr_subgroup_rotate_test.cpp
+171 −0 test/val/val_image_test.cpp
+88 −0 test/val/val_invalid_type_test.cpp
+29 −0 test/val/val_memory_test.cpp
+3 −5 test/val/val_non_uniform_test.cpp
+66 −0 test/val/val_validation_state_test.cpp
+80 −0 tools/val/val.cpp
5 changes: 5 additions & 0 deletions tools/clang/test/CodeGenSPIRV/resource-heap-ext-texture.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
// RUN: %dxc -T cs_6_6 -E main -fspv-use-descriptor-heap -spirv %s | FileCheck %s

// The validator now requires explicit layout for UniformConstant when
// SPV_EXT_descriptor_heap is used (KhronosGroup/SPIRV-Tools#6792). DXC's
// descriptor heap support does not yet emit ArrayStride.
// XFAIL: *

Comment on lines +3 to +7

@damyanp Damyan Pepper (damyanp) Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jonathan Zakharov (@jzakharovnv), Diego Novillo (@dnovillo) - FYI, please let me know if you think we should be dealing with this some other way.

// CHECK: OpCapability DescriptorHeapEXT
// CHECK: OpExtension "SPV_EXT_descriptor_heap"

Expand Down
Loading