Update SPIRV-Tools to 1c336172

[Damyan Pepper (damyanp)]

Fixes #8603: MergeBinaryOpSelect produced an OpSelect with a vector result type and a scalar condition, which is only legal in SPIR-V 1.4+ (KhronosGroup/SPIRV-Tools#6827).

This exposes #8740 where the resource-heap-ext-texture.hlsl test fails validation - for now this is worked around by disabling the test, since #8517 looks like it is reworking it anyway.

Assisted-by: copilot

[Copilot]

Pull request overview

Updates SPIRV-Tools to address invalid OpSelect generation for SPIR-V 1.3 and earlier.

Changes:

• Incorporates the upstream SPIRV-Tools fix for issue #8603.
• Documents the user-visible compiler bug fix in the upcoming release notes.

[Damyan Pepper (damyanp)]

Hmm, this is failing with:

/Users/runner/work/1/s/tools/clang/test/CodeGenSPIRV/resource-heap-ext-texture.hlsl:43:27: warning: SPV_EXT_descriptor_heap support is incomplete.
    SamplerState mySamp = SamplerDescriptorHeap[0];
                          ^
fatal error: generated SPIR-V is invalid: Array must be explicitly laid out with ArrayStride or ArrayStrideIdEXT decorations. Instantiated via '36[%36]' in the UniformConstant storage class using standard layout rules.
This is may be allowed if you enable the scalarBlockLayout feature (or use the --scalar-block-layout command line flag)
  %_runtimearr_type_2d_image = OpTypeRuntimeArray %type_2d_image

Since #8517 is going to remove this test, I'm inclined to disable the test.

[Damyan Pepper (damyanp)]

Jonathan Zakharov (@jzakharovnv), Diego Novillo (@dnovillo) - FYI, please let me know if you think we should be dealing with this some other way.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

tools/clang/test/CodeGenSPIRV/resource-heap-ext-texture.hlsl:6

• Marking the entire test XFAIL means none of its existing FileCheck assertions protect descriptor-heap code generation anymore; any unrelated compiler or output regression is accepted as the expected failure. Please isolate the known validator failure instead—for example, keep the current codegen checks on a -Vd RUN and add a separate expected-failure validation RUN—so this test continues covering the emitted extension, heap variables, access chains, loads, and image operations.

// XFAIL: *