Skip to content

fix : start and stop commands crash when container state diverges from local config#307

Closed
DivyanshuVortex wants to merge 3 commits into
microcks:masterfrom
DivyanshuVortex:fix/startstopcommand
Closed

fix : start and stop commands crash when container state diverges from local config#307
DivyanshuVortex wants to merge 3 commits into
microcks:masterfrom
DivyanshuVortex:fix/startstopcommand

Conversation

@DivyanshuVortex

@DivyanshuVortex DivyanshuVortex commented May 6, 2026

Copy link
Copy Markdown
Contributor

Description :


  • Fixed microcks start to sync with daemon state before starting containers
  • Fixed microcks stop to handle already-removed containers gracefully
  • Fixed UpsertInstance to match by Name instead of ContainerID
  • Prevented duplicate ghostt entries in ~/.config/microcks/config
  • Added GetContainer(name) to inspect real container state from Docker/Podman

Screenshot (685)

Resolves : #306

…er itself

Signed-off-by: DivyanshuVorrtex <divyanshuchandra9027@gmail.com>
@DivyanshuVortex

Copy link
Copy Markdown
Contributor Author

Removed return statemnts following log.Fatalf(). bcoz, log.Fatalf calls os.Exit(1) and terminates the program immediately, making any subsequent return unreachable.

Signed-off-by: DivyanshuVorrtex <divyanshuchandra9027@gmail.com>
@DivyanshuVortex DivyanshuVortex changed the title fix : start and stop commands crash when container state diverges from local config fix : start and stop commands crash when container state diverges from local config May 6, 2026
Signed-off-by: DivyanshuVorrtex <divyanshuchandra9027@gmail.com>
@rootp1

rootp1 commented May 6, 2026

Copy link
Copy Markdown

@DivyanshuVortex, how do you temporarily deploy your PR to build?

@DivyanshuVortex

Copy link
Copy Markdown
Contributor Author

@DivyanshuVortex, how do you temporarily deploy your PR to build?

GitHub Actions is set to auto-run on PR , so the temp Build deploy just kicked off automatically when the PR got opened/updated.

@DivyanshuVortex

Copy link
Copy Markdown
Contributor Author

Hey @Harsh4902, could you please review this PR??? thnx

@Syedowais312

Copy link
Copy Markdown
Contributor

This is fixed in this PR #456

@DivyanshuVortex DivyanshuVortex deleted the fix/startstopcommand branch June 22, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : start and stop commands crash when container state diverges from local config

3 participants