fix: add --name flag to stop command and remove empty println#439
Closed
A-d-i-t-y wants to merge 1 commit into
Closed
fix: add --name flag to stop command and remove empty println#439A-d-i-t-y wants to merge 1 commit into
A-d-i-t-y wants to merge 1 commit into
Conversation
- Added --name flag to stop command so users can specify which Microcks instance to stop, consistent with start command - Removed unnecessary empty fmt.Println() call Closes microcks#438 Signed-off-by: Aditya <aaaditya1909@gmail.com>
Author
|
Hi @Harsh4902 @Vaishnav88sk, I have raised this PR to add --name flag to the stop command. Currently start command supports --name flag but stop command did not, making it inconsistent. This fix allows users to specify which Microcks instance to stop by name. Would love your feedback! |
|
Please check #307 It may cause conflict. |
Author
|
Hi @Vaishnav88sk, thank you for checking! I can see PR #307 already covers significant improvements to the stop command. Closing this PR to avoid conflicts. Sorry for the noise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds --name flag to stop command for consistency with start command.
Problem
The start command supports --name flag to name a Microcks instance
but the stop command has no --name flag:
microcks start --name myinstance ✅ works
microcks stop --name myinstance ❌ flag did not exist
Users could not specify which instance to stop when multiple
instances exist. The stop command always resolved the current
context instead.
Fix
Files Changed
Closes #438