Skip to content

fix: add Conn and *Conn to mapperFor and isUnsafe type switches #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itxaiohanglover wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

fix: add Conn and *Conn to mapperFor and isUnsafe type switches #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sqlx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ func isUnsafe(i interface{}) bool {
return v.unsafe
case *Tx:
return v.unsafe
case Conn:
return v.unsafe
case *Conn:
return v.unsafe
case sql.Rows, *sql.Rows:
return false
default:
Expand All @@ -153,6 +157,10 @@ func mapperFor(i interface{}) *reflectx.Mapper {
return i.Mapper
case *Tx:
return i.Mapper
case Conn:
return i.Mapper
case *Conn:
return i.Mapper
default:
return mapper()
}
Expand Down