fix: add Conn and *Conn to mapperFor and isUnsafe type switches#993
Open
itxaiohanglover wants to merge 1 commit into
Open
fix: add Conn and *Conn to mapperFor and isUnsafe type switches#993itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
Conn was missing from the type switches in mapperFor() and isUnsafe(), causing custom Mapper and unsafe flag to not propagate when creating Stmts from *sqlx.Conn. Fixes jmoiron#975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapperFor()andisUnsafe()were missingConnand*Conncases in their type switches. When creating aStmtfrom a*sqlx.Conn, the customreflectx.Mapperwas not propagated — it fell through to the defaultmapper().This adds
Connand*Connto both type switches, matching the existing handling forDBandTx.Fixes #975
Background
Connhas the sameunsafeandMapperfields asDBandTx, but was overlooked when the type switches were written. PR #992 previously addressed this but was closed by the author due to lack of maintainer engagement.Test plan
mapperFor(conn)returnsconn.Mapperinstead of the default mapperisUnsafe(conn)returnsconn.unsafeinstead offalse