Skip to content

Release prep (part 2): restore JSDoc doc-link + doctor --setup progress line #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbrecht merged 1 commit into from
Jun 13, 2026
+6 −1
Merged

Release prep (part 2): restore JSDoc doc-link + doctor --setup progress line #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cli/src/doctor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ export async function doctorCommand(opts: { config?: string; setup?: boolean } =
// seeds + signs in for real (#19).
if (opts.setup) {
if (config) {
// Progress line: the probe runs the adapter's real setup, so it's bounded
// by the adapter's own waits (e.g. a 30s waitForURL on sign-in) and can
// take a while on the failure path — say so rather than looking hung.
console.log('… running adapter.setup (bounded by your adapter\'s own timeouts)');
try {
await probeAdapterSetup(config.adapter);
checks.push({ name: 'adapter.setup', ok: true, detail: 'ran and tore down cleanly' });
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ export interface Step<S = unknown> {
* `startTransition`-deferred Server Action dispatches its request, settling on
* the pre-mutation UI. For the standard `startTransition` + Server Action +
* `router.refresh()` pattern, prefer `waitFor` on the committed UI (the value
* flipping, a toast appearing) — see docs/writing-tutorials.md "Settling".
* flipping, a toast appearing) — see the "Settling" guide:
* https://github.com/jbrecht/tutorial-forge/blob/main/docs/writing-tutorials.md#settling-waitfor-vs-settleuntil-vs-settlems
*/
settleUntil?: 'load' | 'domcontentloaded' | 'networkidle';
/** Extra hold time (ms) after both narration and action complete. Default 400. */
Expand Down
Loading