Release prep (part 2): restore JSDoc doc-link + doctor --setup progress line#29
Merged
Merged
Conversation
From umami's 0.10.0 dogfood: - The settleUntil JSDoc (which ships in dist/types.d.ts) pointed at "docs/writing-tutorials.md", a path not in the published package. Point it at the hosted docs URL so the reference resolves from an installed package. - doctor --setup now prints a progress line before running the probe, so the failure path (bounded by the adapter's own waitForURL timeout) reads as work in progress rather than a hang. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two fixes were authored for PR #26 but #26 merged before the commit landed, so they never reached
main. Restoring them here before tagging 0.10.0.settleUntilJSDoc (ships indist/types.d.ts) pointed atdocs/writing-tutorials.md, a path not in the published package. Now a hosted GitHub URL.doctor --setupprogress line (umami concern Idle speed-up: compress dead time between action end and narration end #3) — prints… running adapter.setup (bounded by your adapter's own timeouts)before the probe, so the failure path doesn't read as a hang.Without this, a published 0.10.0 would still carry the broken doc reference umami flagged. Cherry-picked from the original
5177c8c.