Skip to content

Enable synchronous texture streaming for OVRTX - #6957

Draft
huidongc wants to merge 1 commit into
isaac-sim:developfrom
huidongc:enable-synchronous-texture-streaming-for-ovrtx
Draft

Enable synchronous texture streaming for OVRTX#6957
huidongc wants to merge 1 commit into
isaac-sim:developfrom
huidongc:enable-synchronous-texture-streaming-for-ovrtx

Conversation

@huidongc

@huidongc huidongc commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Set texture_streaming_mode to SYNCHRONOUS on ovrtx.RendererConfig to improve cross-run render determinism. Requires ovrtx>=0.4.1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml — CI handles that)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Set texture_streaming_mode to SYNCHRONOUS on the
internal RendererConfig to improve cross-run render
determinism. Requires ovrtx>=0.4.1.
@huidongc
huidongc requested a review from a team August 7, 2026 06:20
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Aug 7, 2026
@huidongc
huidongc marked this pull request as draft August 7, 2026 06:21
@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR enables synchronous texture streaming in OVRTX to improve cross-run rendering determinism and documents the new ovrtx 0.4.1 requirement.

  • Imports TextureStreamingMode and configures RendererConfig to use synchronous streaming.
  • Updates installation guidance and adds a changelog fragment.
  • The repository dependency constraints were not raised to the newly required minimum version.

Confidence Score: 4/5

The PR should not merge until the ovrtx dependency constraints are raised to 0.4.1 so supported installation paths cannot produce an incompatible renderer environment.

The renderer unconditionally imports and uses an API documented as requiring ovrtx 0.4.1, while repository extras and CI installation metadata continue to allow ovrtx 0.4.0.

Files Needing Attention: source/isaaclab_ov/isaaclab_ov/renderers/ovrtx_renderer.py and root pyproject.toml

Important Files Changed

Filename Overview
source/isaaclab_ov/isaaclab_ov/renderers/ovrtx_renderer.py Enables synchronous texture streaming but uses a 0.4.1-only API while supported dependency metadata still permits ovrtx 0.4.0.
source/isaaclab_ov/changelog.d/enable-synchronous-texture-streaming.rst Accurately documents the renderer change and its ovrtx 0.4.1 minimum-version requirement.

Reviews (1): Last reviewed commit: "Enable synchronous OVRTX texture streami..." | Re-trigger Greptile

Renderer,
RendererConfig,
Semantic,
TextureStreamingMode,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Dependency permits incompatible OVRTX API

When a supported installation path resolves ovrtx==0.4.0, this unconditional TextureStreamingMode import uses an API that requires 0.4.1, causing the OVRTX renderer module to fail to import. Raise the lower bound in the repository's ov and ovrtx dependency constraints so installations cannot select the incompatible release.

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The change enables synchronous texture streaming at the sole OVRTX RendererConfig construction site and records the new ovrtx 0.4.1 requirement. The proposed packaging finding is not supported because the supplied context does not show the repository’s current ovrtx dependency constraint or establish that the ovrtx extra can resolve 0.4.0.

  • Design and architecture: Applying the deterministic streaming mode when constructing OVRTXRenderer keeps the policy centralized and leaves the ovstage and legacy rendering paths unchanged.
  • API: No Isaac Lab public symbols, signatures, or return types change. The compatibility surface reviewed was the new use of TextureStreamingMode, the stated ovrtx 0.4.1 minimum, and the installation guidance emitted when ovrtx is absent.
  • Implementation: TextureStreamingMode.SYNCHRONOUS is passed unconditionally to the existing renderer configuration, and the guarded import remains correct for a missing ovrtx package. A missing symbol on an older installed wheel would raise ImportError, but the patch does not include enough dependency metadata context to demonstrate that such a wheel remains permitted by the project’s declared constraints.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant