Enable synchronous texture streaming for OVRTX - #6957
Conversation
Set texture_streaming_mode to SYNCHRONOUS on the internal RendererConfig to improve cross-run render determinism. Requires ovrtx>=0.4.1.
Greptile SummaryThe PR enables synchronous texture streaming in OVRTX to improve cross-run rendering determinism and documents the new ovrtx 0.4.1 requirement.
Confidence Score: 4/5The PR should not merge until the ovrtx dependency constraints are raised to 0.4.1 so supported installation paths cannot produce an incompatible renderer environment. The renderer unconditionally imports and uses an API documented as requiring ovrtx 0.4.1, while repository extras and CI installation metadata continue to allow ovrtx 0.4.0. Files Needing Attention: source/isaaclab_ov/isaaclab_ov/renderers/ovrtx_renderer.py and root pyproject.toml Important Files Changed
Reviews (1): Last reviewed commit: "Enable synchronous OVRTX texture streami..." | Re-trigger Greptile |
| Renderer, | ||
| RendererConfig, | ||
| Semantic, | ||
| TextureStreamingMode, |
There was a problem hiding this comment.
Dependency permits incompatible OVRTX API
When a supported installation path resolves ovrtx==0.4.0, this unconditional TextureStreamingMode import uses an API that requires 0.4.1, causing the OVRTX renderer module to fail to import. Raise the lower bound in the repository's ov and ovrtx dependency constraints so installations cannot select the incompatible release.
There was a problem hiding this comment.
Isaac Lab Review Bot
The change enables synchronous texture streaming at the sole OVRTX RendererConfig construction site and records the new ovrtx 0.4.1 requirement. The proposed packaging finding is not supported because the supplied context does not show the repository’s current ovrtx dependency constraint or establish that the ovrtx extra can resolve 0.4.0.
- Design and architecture: Applying the deterministic streaming mode when constructing
OVRTXRendererkeeps the policy centralized and leaves the ovstage and legacy rendering paths unchanged. - API: No Isaac Lab public symbols, signatures, or return types change. The compatibility surface reviewed was the new use of
TextureStreamingMode, the stated ovrtx 0.4.1 minimum, and the installation guidance emitted when ovrtx is absent. - Implementation:
TextureStreamingMode.SYNCHRONOUSis passed unconditionally to the existing renderer configuration, and the guarded import remains correct for a missing ovrtx package. A missing symbol on an older installed wheel would raiseImportError, but the patch does not include enough dependency metadata context to demonstrate that such a wheel remains permitted by the project’s declared constraints.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Description
Set texture_streaming_mode to SYNCHRONOUS on
ovrtx.RendererConfigto improve cross-run render determinism. Requires ovrtx>=0.4.1.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there