Suppress OVRTX API deprecation warnings - #6950
Conversation
|
Too many files changed for review (2800 files, 100 file limit). |
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR conditionally suppresses noisy OVRTX initialization and teardown logs and adds the required isaaclab_ov changelog fragment. However, legacy multi-environment initialization re-enters the same single-use force_log_level context manager, which can abort initialization.
- Design and architecture: Containing third-party log suppression around specific OVRTX calls is appropriately scoped, but the initialization path must not retain and reuse a single-use generator context manager across separate operation groups.
- API: No public symbols or signatures change. The observable change is limited to OVRTX logging verbosity during legacy initialization and teardown, and the changelog fragment correctly documents it under
Fixed. - Implementation: The teardown path creates a fresh suppression context for
reset_stage, but_initialize_from_spec_legacycreates_level_ctxonce and enters it around both stage loading and multi-environment cloning. Whenforce_log_levelis selected, the second entry is invalid. Construct a fresh context for each block or place both groups under one context.
Significant concerns. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
| spec: Tiled camera description (resolution, paths, data types). | ||
| """ | ||
| _suppress = logging.getLogger().getEffectiveLevel() > logging.DEBUG | ||
| _level_ctx = force_log_level(logging.ERROR) if _suppress else contextlib.nullcontext() |
There was a problem hiding this comment.
🔴 Critical · Implementation — Reused suppression context entered twice
_level_ctx is created once and entered by two separate with statements (lines 531 and 537). A force_log_level context manager built via contextlib.contextmanager is single-use, so the second entry raises RuntimeError: generator didn't yield on the common path (default WARNING root level with num_envs > 1), aborting legacy initialization. Call force_log_level(...)/nullcontext() freshly per block, as _close_legacy already does, or wrap both operation groups in one context.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there