Add runtime scene attribute updates - #6944
Draft
ruziniuuuuu wants to merge 3 commits into
Draft
Conversation
Signed-off-by: ruziniuuuuu <ruziniuuuuu@gmail.com>
Signed-off-by: ruziniuuuuu <ruziniuuuuu@gmail.com>
Signed-off-by: ruziniuuuuu <ruziniuuuuu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a renderer-neutral
RenderContext.update_scene_attribute(...)API for targeted non-physics scene state such as lights and material asset inputs. Renderers that consume live USD keep the base no-op behavior; backends with a private scene representation can synchronize the update explicitly.The OVRTX implementation supports immediate updates in both legacy and ovstage modes. Updates submitted before stage initialization are copied, queued, and flushed after stage load and environment cloning. The ovstage path also preserves USD asset-path semantics for HDR and material inputs.
Fixes #6943
Type of change
Screenshots
Not applicable; this is a renderer API and synchronization contract change.
Validation
uv run --frozen isaaclab -f.venv/bin/pytest source/isaaclab/test/renderers/test_simulation_render_context.py -q— 13 passedPYTHONPATH=source/isaaclab:source/isaaclab_ov <ovrtx-env>/bin/pytest source/isaaclab_ov/test/test_ovrtx_renderer_contract.py -q— 26 passed with OVRTX installed.venv/bin/python tools/changelog/cli.py check developASSET_STRINGattributes and advanced the write floor successfullyChecklist
uv run --frozen isaaclab -fCONTRIBUTORS.md