Skip to content

test: Update RTX goldens for the new denoiser default - #6926

Open
nvsekkin wants to merge 8 commits into
isaac-sim:developfrom
nvsekkin:esekkin/regen-rtx-goldens-new-isaacsim
Open

test: Update RTX goldens for the new denoiser default#6926
nvsekkin wants to merge 8 commits into
isaac-sim:developfrom
nvsekkin:esekkin/regen-rtx-goldens-new-isaacsim

Conversation

@nvsekkin

@nvsekkin nvsekkin commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Pins CI to the first Isaac Sim build enabling responsive denoising by default.
  • Regenerates 20 task and 5 visualizer RTX goldens.
  • Updates only affected RGB/RGBA outputs; other AOVs remain unchanged.
  • Keeps responsive denoising enabled.
  • Marks Kit + Newton tiled pause-frame stability as expected failure under NVBug 6570125 while retaining separate Newton visualizer coverage.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml — CI handles that)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Kit 9e5dd32c (OMPE-65433) flips /rtx/dldenoiser/responsiveDenoising to
true, which shifts every RTX-rendered golden. The change is intentional
upstream work to reduce ghosting, so take the new build and regenerate
the goldens instead of holding CI on the pre-change pin.
The new DLSS-RR default shifts every RT2-rendered frame, so the rgb and
rgba AOVs land outside threshold on all six rendering-correctness scenes
and on the Kit visualizer captures. Every other AOV stays under.

Goldens are taken from the rendering-correctness and isaaclab_visualizers
jobs of the run against the newly pinned image.
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Aug 6, 2026
@nvsekkin
nvsekkin marked this pull request as ready for review August 6, 2026 14:08
@nvsekkin
nvsekkin requested a review from a team August 6, 2026 14:08

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The PR updates the pinned Isaac Sim CI image digest for the DLSS-RR denoiser-default change and refreshes the corresponding RTX and Kit rendering goldens, with test-only changelog fragments for both affected packages.

  • Design and architecture: The change remains limited to shared CI image configuration and rendering test fixtures. The pin is documented with the motivating Kit revision and issue, preserving traceability between the runtime change and regenerated baselines.
  • API: No public APIs, CLI arguments, configuration schemas, exports, or documented user behavior change. The required per-package changelog handling is satisfied with .skip fragments appropriate for test-only changes.
  • Implementation: The patch updates 20 task golden LFS pointers and five visualizer captures. The task updates are confined to RGB/RGBA RTX-renderer baselines, including the registered cartpole task’s default-renderer variants, while unrelated AOV and simple-shading fixtures remain untouched. Binary image contents cannot be assessed from the textual patch, so final confidence still depends on the rendering test results and provenance of the regenerated captures.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Pins CI to the Isaac Sim build that enables responsive denoising by default and aligns the affected rendering baselines with that build.

  • Regenerates affected RTX RGB/RGBA task and visualizer goldens.
  • Separates Newton tiled visualizer coverage by visualizer kind.
  • Marks the known Kit pause-frame instability as an expected failure while retaining Newton visualizer coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/config.yaml Pins the Isaac Sim CI image to the responsive-denoising build used to generate the updated rendering baselines.
source/isaaclab_visualizers/test/test_visualizer_integration_newton.py Parameterizes tiled visualizer testing so only the known Kit stability case is expected to fail while Newton remains independently covered.
source/isaaclab_tasks/test/golden_images Updates the affected task RTX RGB and RGBA golden-image pointers for the newly pinned renderer behavior.
source/isaaclab_visualizers/test/golden_images Regenerates five visualizer rendering baselines against the pinned Isaac Sim build.

Reviews (2): Last reviewed commit: "test: Xfail Kit Newton pause stability" | Re-trigger Greptile

nvsekkin and others added 4 commits August 6, 2026 22:21
Kit 9e5dd32c keeps changing DLSS-RR pixels while simulation is paused.
Disable responsive denoising only in this integration-test process so
pause behavior remains testable without changing application defaults.
Responsive DLSS-RR continues temporal accumulation on static frames, so
pixel identity is not a valid pause signal for Kit on Newton. Validate
the simulation flag, physics-step counter, and body state instead while
keeping strict frame checks for deterministic render paths.
Track the responsive-denoising regression with NVBug 6570125 instead of
silently bypassing its assertion. Split the visualizer cases so Newton's
tiled integration path remains fully covered.
@nvsekkin nvsekkin changed the title test: Regenerate RTX goldens for the new denoiser default test: Update RTX goldens for the new denoiser default Aug 7, 2026
@nvsekkin

nvsekkin commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant