test: Update RTX goldens for the new denoiser default - #6926
Open
nvsekkin wants to merge 8 commits into
Open
Conversation
Kit 9e5dd32c (OMPE-65433) flips /rtx/dldenoiser/responsiveDenoising to true, which shifts every RTX-rendered golden. The change is intentional upstream work to reduce ghosting, so take the new build and regenerate the goldens instead of holding CI on the pre-change pin.
The new DLSS-RR default shifts every RT2-rendered frame, so the rgb and rgba AOVs land outside threshold on all six rendering-correctness scenes and on the Kit visualizer captures. Every other AOV stays under. Goldens are taken from the rendering-correctness and isaaclab_visualizers jobs of the run against the newly pinned image.
nvsekkin
marked this pull request as ready for review
August 6, 2026 14:08
nvsekkin
requested review from
StafaH,
kellyguo11,
matthewtrepte,
myurasov-nv and
ooctipus
as code owners
August 6, 2026 14:08
Contributor
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR updates the pinned Isaac Sim CI image digest for the DLSS-RR denoiser-default change and refreshes the corresponding RTX and Kit rendering goldens, with test-only changelog fragments for both affected packages.
- Design and architecture: The change remains limited to shared CI image configuration and rendering test fixtures. The pin is documented with the motivating Kit revision and issue, preserving traceability between the runtime change and regenerated baselines.
- API: No public APIs, CLI arguments, configuration schemas, exports, or documented user behavior change. The required per-package changelog handling is satisfied with
.skipfragments appropriate for test-only changes. - Implementation: The patch updates 20 task golden LFS pointers and five visualizer captures. The task updates are confined to RGB/RGBA RTX-renderer baselines, including the registered cartpole task’s default-renderer variants, while unrelated AOV and simple-shading fixtures remain untouched. Binary image contents cannot be assessed from the textual patch, so final confidence still depends on the rendering test results and provenance of the regenerated captures.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Contributor
Greptile SummaryPins CI to the Isaac Sim build that enables responsive denoising by default and aligns the affected rendering baselines with that build.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "test: Xfail Kit Newton pause stability" | Re-trigger Greptile |
Kit 9e5dd32c keeps changing DLSS-RR pixels while simulation is paused. Disable responsive denoising only in this integration-test process so pause behavior remains testable without changing application defaults.
Responsive DLSS-RR continues temporal accumulation on static frames, so pixel identity is not a valid pause signal for Kit on Newton. Validate the simulation flag, physics-step counter, and body state instead while keeping strict frame checks for deterministic render paths.
Track the responsive-denoising regression with NVBug 6570125 instead of silently bypassing its assertion. Split the visualizer cases so Newton's tiled integration path remains fully covered.
Collaborator
Author
|
@greptile review |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there