Add Plotly runtime dependency - #1212
Conversation
Signed-off-by: zhx06 <zihaox@nvidia.com>
| "sbi", | ||
| "scipy", | ||
| "matplotlib", | ||
| "plotly", |
There was a problem hiding this comment.
🔵 Worth saying why plotly is here
The other non-obvious deps in this list name the module that imports them (see sbi just above), and plotly's only importer is isaaclab_arena_examples/relations/relation_solver_visualizer.py — nothing in isaaclab_arena itself. Could we add the same one-liner, and is the dev extra (where jupyter already lives) a better home, given the sole consumer is an example notebook?
| "plotly", | |
| # Relation solver visualization (isaaclab_arena_examples.relations.relation_solver_visualizer), | |
| # imported at module level. | |
| "plotly", |
🤖 Isaac Lab-Arena Review BotSummaryDeclares Findings🔵 Improvement: Test Coverage
Nit (not a code finding)The last two bullets of the PR description contain a literal VerdictShip it. |
Summary
Declare Plotly as a runtime dependency for the relation solver visualization examples.
pyproject.tomlanduv.lock.ModuleNotFoundError: No module named 'plotly'in the dummy ObjectPlacer example.\n- Verify the example completes successfully in Docker.