Cherry pick: add Plotly runtime dependency (#1212) - #1213
Conversation
| "sbi", | ||
| "scipy", | ||
| "matplotlib", | ||
| "plotly", |
There was a problem hiding this comment.
🔵 Worth a note saying why plotly is here
The neighbours in this list explain who imports them (sbi for the sensitivity analysis, pandas for the GR00T HDF5 conversion). plotly's only importer is isaaclab_arena_examples/relations/relation_solver_visualizer.py, which isn't guessable from the name — same one-liner here?
| "plotly", | |
| # Relation solver 3D visualization | |
| # (isaaclab_arena_examples.relations.relation_solver_visualizer), imported at module level. | |
| "plotly", |
🤖 Isaac Lab-Arena Review BotSummaryBackports the Findings🔵 Improvement: Cherry-pick orderingWorth confirming: the source PR #1212 is still open on Test CoverageNo test needed — this is a packaging change, and the install itself is the verification. The VerdictMinor fixes needed |
Greptile SummaryDeclares Plotly as a runtime dependency for relation-solver visualization examples and updates the release lockfile to resolve Plotly 7.0.0 with its transitive dependencies. Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The declared dependency and generated lockfile are consistent, and the locked Plotly release is compatible with the project’s Python constraint and visualization API usage. Important Files Changed
Reviews (2): Last reviewed commit: "Add Plotly runtime dependency" | Re-trigger Greptile |
614d823 to
ec14cb4
Compare
| "sbi", | ||
| "scipy", | ||
| "matplotlib", | ||
| "plotly", |
There was a problem hiding this comment.
🔵 This lands under a comment that names the wrong module
plotly sits directly beneath the "Sensitivity analysis" comment, but nothing in isaaclab_arena.analysis.sensitivity imports it — the only importer in the repo is isaaclab_arena_examples/relations/relation_solver_visualizer.py. Every other non-obvious dep in this list says who pulls it in, so could we give plotly its own note and keep the grouping accurate?
| "plotly", | |
| # 3D relation-solver visualization | |
| # (isaaclab_arena_examples.relations.relation_solver_visualizer), imported at module level. | |
| "plotly", |
Signed-off-by: zhx06 <zihaox@nvidia.com> (cherry picked from commit b19cf04)
ec14cb4 to
e34f296
Compare
Summary
Cherry-pick the Plotly runtime dependency fix from #1212 onto
release/0.3.0.