chore(ci): Check every maven central version for android publish#2512
Open
OS-pedrogustavobilro wants to merge 1 commit intomainfrom
Open
chore(ci): Check every maven central version for android publish#2512OS-pedrogustavobilro wants to merge 1 commit intomainfrom
OS-pedrogustavobilro wants to merge 1 commit intomainfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a simple PR to check for all versions published to maven central, instead of just the latest one.
After this PR is merged, I'll still need to:
Change Type
Rationale / Problems Fixed
In a situation where
package.jsonversion is older than the latest version on Maven Central (can happen if we trigger native android publish from a maintenance branch, or for plugins that have migrated from this repository like camera did recently), the publishing script was assuming that the version needed to be published, and would often fail because said version would already exist in Maven Central.Tests or Reproductions
I ran it locally and also dry-ran in GitHub actions (without publishing part), it is correctly detecting the plugins that have the latest version in maven central, the ones who don't, and the ones who have the version in maven central that's not the latest (for
mainbranch, the one example of that is camera, of which latest is 8.1.0,mainhas 8.0.2; prior to this PR it would try to publish 8.0.2 and fail with message that 8.0.2 already exists)