Skip to content

chore: do not publish camera to CocoaPods#2513

Merged
OS-pedrogustavobilro merged 2 commits intomainfrom
chore/camera-no-cocoapods
Apr 16, 2026
Merged

chore: do not publish camera to CocoaPods#2513
OS-pedrogustavobilro merged 2 commits intomainfrom
chore/camera-no-cocoapods

Conversation

@OS-pedrogustavobilro
Copy link
Copy Markdown
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro commented Apr 14, 2026

Description

Remove the cocoa pods publish command for Camera Plugin.

Because CocoaPods Publish workflow is triggered per plugin directory, removing this command means that if someone tries to push Camera to Trunk from this Repo (needs to explicitly list camera in plugin list input to workflow), the GitHub action will fail.

After this one is approved / merged I will also open a PR for 7.x, for filesystem and geolocation.

Change Type

  • Fix
  • Feature
  • Refactor
  • Breaking Change
  • Documentation
  • Other

Rationale / Problems Fixed

Capacitor camera is now housed in https://github.com/ionic-team/capacitor-camera, and main / 8.x in this repo is meant to serve only for historical purposes.

To avoid GitHub Workflow failures and unforeseen issues, we should not try to push camera plugin 8.x to Trunk from this repo.

Notes / Comments

In terms of avoiding GitHub Workflow failures in Android, refer to #2512

@OS-pedrogustavobilro OS-pedrogustavobilro requested a review from a team April 14, 2026 13:42
Copy link
Copy Markdown
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed since camera was removed from the workspace in the package.json, so since the ci publish runs lerna run publish:cocoapod, it won't be run for camera plugin.

If you want to prevent a manual publish, maybe you can remove the whole script rather than changing it to an echo

@OS-pedrogustavobilro
Copy link
Copy Markdown
Contributor Author

I don't think this is needed since camera was removed from the workspace in the package.json, so since the ci publish runs lerna run publish:cocoapod, it won't be run for camera plugin.

Don't think that's the case, looking at https://github.com/ionic-team/capacitor-plugins/blob/main/.github/workflows/publish-ios.yml, it does npm run publish:cocoapod from each plugin directory (where the list of plugins is an input to the workflow). The root package.json has the lerna command as you state, but it doesn't actually get triggered in the workflow

If you want to prevent a manual publish, maybe you can remove the whole script rather than changing it to an echo

Yeah, that works too, my idea was to pass silently instead of failing, but I suppose it's better to be an explicit failure, I'll make that change

@OS-pedrogustavobilro OS-pedrogustavobilro merged commit 94af35d into main Apr 16, 2026
8 checks passed
@OS-pedrogustavobilro OS-pedrogustavobilro deleted the chore/camera-no-cocoapods branch April 16, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants