Skip to content

style(lint, android): format+ignore version file to avoid flaky lint exit #9101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikehardy wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −9
Open

style(lint, android): format+ignore version file to avoid flaky lint exit #9101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,4 @@ npmPreapprovedPackages:
- '@react-native-firebase/*'
- 'firebase@12.15.0' # If adopting recent firebase-js-sdk, specify directly here
- 'firebase-tools@15.22.4'
- 'google-java-format@2.3.0'
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"codegen:verify": "node ./scripts/codegen-verify.mjs && git diff --exit-code -- 'packages/*/android/**/generated/**' 'packages/*/ios/generated/**'",
"lint": "yarn lint:js && yarn lint:android && yarn lint:ios:check",
"lint:js": "eslint packages/* --max-warnings=0",
"lint:android": "(find packages/*/android/src -name '*.java' -not -path '*/generated/*' -print0 | xargs -0 google-java-format --set-exit-if-changed --replace || (echo \"\n\nandroid formatting error - please re-run\n\n\" && exit 1)) && (git diff --exit-code packages/*/android/src || (echo \"\n\nandroid files changed from linting, please examine and commit result\n\n\" && exit 1))",
"lint:android": "(find packages/*/android/src -name '*.java' -not -path '*/generated/*' ! -name 'ReactNativeFirebaseVersion.java' -print0 | xargs -0 google-java-format --set-exit-if-changed --replace || (echo \"\n\nandroid formatting error - please re-run\n\n\" && exit 1)) && (git diff --exit-code packages/*/android/src || (echo \"\n\nandroid files changed from linting, please examine and commit result\n\n\" && exit 1))",
"lint:ios:check": "find packages/*/ios -type f \\( -name '*.h' -o -name '*.cpp' -o -name '*.m' -o -name '*.mm' \\) -not -path '*/generated/*' -print0 | xargs -0 clang-format --style=Google -n -Werror",
"lint:ios:fix": "find packages/*/ios -type f \\( -name '*.h' -o -name '*.cpp' -o -name '*.m' -o -name '*.mm' \\) -not -path '*/generated/*' -print0 | xargs -0 clang-format -i --style=Google",
"lint:markdown": "eslint \"docs/**/*.mdx\" --max-warnings=0 && prettier --check \"docs/**/*.mdx\"",
Expand Down Expand Up @@ -105,7 +105,7 @@
"firebase": "^12.15.0",
"firebase-tools": "^15.22.4",
"genversion": "^3.2.0",
"google-java-format": "^2.2.0",
"google-java-format": "^2.3.0",
"jest": "^30.3.0",
"lerna": "^9.0.7",
"patch-package": "^8.0.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/app/scripts/genversion-android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ const outputPath = path.resolve(
'src/reactnative/java/io/invertase/firebase/app',
'ReactNativeFirebaseVersion.java',
);
const template = `
package io.invertase.firebase.app;
const template = `package io.invertase.firebase.app;

/*
* Copyright (c) 2016-present Invertase Limited & Contributors
*
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13406,16 +13406,16 @@ __metadata:
languageName: node
linkType: hard

"google-java-format@npm:^2.2.0":
version: 2.2.0
resolution: "google-java-format@npm:2.2.0"
"google-java-format@npm:^2.3.0":
version: 2.3.0
resolution: "google-java-format@npm:2.3.0"
dependencies:
async: "npm:^3.2.6"
glob: "npm:^13.0.0"
resolve: "npm:^1.22.11"
bin:
google-java-format: index.js
checksum: 10/32bf7cffca834e79a32036baff49fd4e57bf5db19f050cebfa217c2edff1d9031dd65ae66986bb5ddc50b1e304fc380024fb5f0ef9675095ec0a6493e74227c5
checksum: 10/1f3af54590bb9422b051ef04281d505647a9beb6c63ce893d5126e57217149f349f8bfc1e74df83073a30e2b9c7db065dba3d79fd601ea2239a795f78ebf9dbb
languageName: node
linkType: hard

Expand Down Expand Up @@ -21393,7 +21393,7 @@ __metadata:
firebase: "npm:^12.15.0"
firebase-tools: "npm:^15.22.4"
genversion: "npm:^3.2.0"
google-java-format: "npm:^2.2.0"
google-java-format: "npm:^2.3.0"
jest: "npm:^30.3.0"
lerna: "npm:^9.0.7"
patch-package: "npm:^8.0.1"
Expand Down
Loading