style(lint, android): format+ignore version file to avoid flaky lint exit#9101
Open
mikehardy wants to merge 1 commit into
Open
style(lint, android): format+ignore version file to avoid flaky lint exit#9101mikehardy wants to merge 1 commit into
mikehardy wants to merge 1 commit into
Conversation
8979aaa to
788acbd
Compare
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9101 +/- ##
=============================================
- Coverage 58.66% 46.19% -12.47%
+ Complexity 1617 1616 -1
=============================================
Files 503 503
Lines 39180 39184 +4
Branches 5807 5744 -63
=============================================
- Hits 22981 18097 -4884
- Misses 14800 19807 +5007
+ Partials 1399 1280 -119
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReactNativeFirebaseVersion.javafrom genversion in google-java-format-compatible layout (no leading newline; blank line afterpackage).lint:androidso--set-exit-if-changedcannot fail when tracked sources are already clean.Motivation
lint:androidcould fail intermittently (~1 in 20–30 runs) withgoogle-java-formatexit 1 and an emptygit diff. Investigation showed the gitignored generatedReactNativeFirebaseVersion.javawas included in the formatter pass afterprepareregenerated it with slightly non-compliant whitespace.Test plan
node packages/app/scripts/genversion-android.jsthengoogle-java-format --set-exit-if-changedon the version file exits 0yarn lint:androidpassesChecklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/**/e2ejesttests added or updated inpackages/**/__tests__