Skip to content

fix: replace bare except clauses with except Exception #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmSach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace bare except clauses with except Exception #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions handlers/admin_conversations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,8 +2001,8 @@ async def store_logo_value(update: Update, context: ContextTypes.DEFAULT_TYPE):
if settings.store_logo_path and os.path.exists(settings.store_logo_path):
try:
os.remove(settings.store_logo_path)
except:
pass
except Exception as e:
print(f"Error deleting old logo {settings.store_logo_path}: {e}")

settings.store_logo_path = file_path
session.commit()
Expand Down
12 changes: 6 additions & 6 deletions handlers/admin_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,8 +1259,8 @@ async def admin_confirm_payment_callback(update: Update, context: ContextTypes.D
chat_id=user_telegram_id,
text=f"✅ Payment Confirmed!\n\n💰 Amount: {format_price(amount)}\n💵 New Balance: {format_price(new_balance)}"
)
except:
pass
except Exception as e:
print(f"Error notifying user {user_telegram_id}: {e}")

# Go back to payment confirmation menu
await admin_confirm_order_menu(update, context)
Expand Down Expand Up @@ -1308,8 +1308,8 @@ async def admin_cancel_payment_callback(update: Update, context: ContextTypes.DE
chat_id=user_telegram_id,
text=f"❌ Payment Cancelled\n\n💰 Amount: {format_price(amount)}\n\nYour payment was not confirmed. Please contact support if you believe this is an error."
)
except:
pass
except Exception as e:
print(f"Error notifying user {user_telegram_id}: {e}")

# Go back to payment cancellation menu
await admin_cancel_order_menu(update, context)
Expand Down Expand Up @@ -1351,8 +1351,8 @@ async def admin_cancel_order_callback(update: Update, context: ContextTypes.DEFA
chat_id=user.telegram_id,
text=f"❌ Order #{order.id} has been cancelled by admin.\n💰 Refund: {format_price(order.total_amount)}"
)
except:
pass
except Exception as e:
print(f"Error notifying user {user.telegram_id}: {e}")

# Refresh order details
await admin_order_detail_callback(update, context)
Expand Down