fix: replace bare except clauses with except Exception#37
Open
AmSach wants to merge 1 commit into
Open
Conversation
Bare `except:` clauses silently swallow ALL exceptions including `KeyboardInterrupt` and `SystemExit`, which can hide real bugs and prevent graceful shutdown. This replaces four such blocks across admin payment/order notification paths with `except Exception as e:` that logs the failure to stdout for visibility. Affected handlers: - admin_confirm_payment_callback - admin_cancel_payment_callback - admin_cancel_order_callback - store_logo_value (admin_conversations)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced 4 bare
except:clauses inhandlers/admin_handlers.pyandhandlers/admin_conversations.pywithexcept Exception as e:that logs the error.A bare
except:clause also catchesSystemExitandKeyboardInterrupt, which prevents users from cleanly stopping the bot (e.g. via Ctrl+C) and can mask real bugs. Replacing it withexcept Exception as e:is the standard Python fix and now prints the error so silent failures don't go unnoticed.Before
After
Affected functions:
admin_confirm_payment_callback(handlers/admin_handlers.py)admin_cancel_payment_callback(handlers/admin_handlers.py)admin_cancel_order_callback(handlers/admin_handlers.py)store_logo_value(handlers/admin_conversations.py)— Sent via @AmSach bot