Add renderer info query API - #3340
copybara-service[bot] merged 1 commit into
Conversation
4a0c4ce to
4679fad
Compare
|
I guess once this PR is merged, wheels will be built, and the render version will be queryable? Leaving a note here so I get updated. Looking forward to this functionality. 🙌 |
|
Thanks! |
4679fad to
1b43bd1
Compare
|
Rebased this onto current Validated with:
I also tried a narrow Filament/MJR-compat configure. It still hits the separate dear_imgui/SDL2 source-build issue covered by #3252, so I’m not mixing that fix into this API PR. |
1b43bd1 to
d23ff84
Compare
|
Rebased this onto current main and fixed the conflict in Local validation:
@haroonq once fresh CI goes green again, I think this is unblocked for submit. 🙏 |
|
Thanks for the reviews. One thing I can’t inspect from the fork side: @haroonq / @mmossg, could one of you check whether that internal failure needs a code tweak from me or just an internal retry/submit-side fix? |
|
Yes, the issue is on our end and I'm investigating. It's a little unclear why it's not working at the moment, but hopefully we can resolve it soon. Thanks for your contributions! It is appreciated. |
Split out from #3254 in response to Haroon's request for smaller Filament PRs.
Summary
mjrRendererInfoplusmjr_defaultRendererInfoandmjr_getRendererInfoto report the active renderer family and graphics backend.classic/opengl, noop asnoop/none, and Filament asfilamentwith its selected backend.Validation
git diff --checkpython3 -m py_compile python/mujoco/introspect/functions.py python/mujoco/introspect/structs.py python/mujoco/bindings_test.pyPYTHONPATH=/tmp/mujoco-check-pydeps:python/mujoco python3 python/mujoco/codegen/generate_function_traits.py >/tmp/mujoco-function-traits-check.hPYTHONPATH=/tmp/mujoco-check-pydeps:python/mujoco python3 python/mujoco/codegen/generate_enum_traits.py >/tmp/mujoco-enum-traits-check.hcmake -S . -B /tmp/mujoco-renderer-info-build -DMUJOCO_BUILD_TESTS=ON -DMUJOCO_TEST_PYTHON_UTIL=OFF -DCMAKE_BUILD_TYPE=Releasecmake --build /tmp/mujoco-renderer-info-build --target mujoco -j2Notes
backend_versionis reserved and currently returns an empty string until backend-specific version extraction is added.