Skip to content

chore(scm-project-creation-flow): Persisting messaging integration no…#119477

Merged
Abdkhan14 merged 22 commits into
abdk/scm-project-creation-disabled-tooltipfrom
abdk/scm-project-creation-alert-persistence
Jul 15, 2026
Merged

chore(scm-project-creation-flow): Persisting messaging integration no…#119477
Abdkhan14 merged 22 commits into
abdk/scm-project-creation-disabled-tooltipfrom
abdk/scm-project-creation-alert-persistence

Conversation

@Abdkhan14

@Abdkhan14 Abdkhan14 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Fixes: LINEAR TICKET

The messaging-integration notification selection (provider, integration, channel) wasn't persisted, so navigating away from project details and back lost it and could spawn a duplicate project on re-submit. This persists the selection as a serializable notificationAction on the project-details form state that already round-trips through session storage, and restores it on the next mount by feeding it back in as the notification picker's default action. To keep the saved snapshot identical to what actually gets submitted, the provider-to-IntegrationAction mapping is extracted into a shared buildIntegrationAction helper that both the rule-creation path and the persistence path call.

The restore also feeds the reuse check: returning with an unchanged selection reuses the existing project instead of creating a new one, while changing the channel creates a fresh one. Covered by new useScmProjectDetails tests for persist/restore/reuse plus the channel-change case, and existing specs updated.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 12, 2026
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ no issues found

@Abdkhan14
Abdkhan14 marked this pull request as ready for review July 14, 2026 16:11
@Abdkhan14
Abdkhan14 requested a review from a team as a code owner July 14, 2026 16:11
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts Outdated
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx Outdated
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx Outdated
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx Outdated
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts Outdated
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts Outdated
@Abdkhan14
Abdkhan14 requested a review from jaydgoss July 15, 2026 15:12
Base automatically changed from abdk/scm-project-creation-flow-discord-channel to abdk/scm-project-creation-disabled-tooltip July 15, 2026 15:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d02f2b. Configure here.

Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts
Comment thread static/app/views/onboarding/components/useScmProjectDetails.ts
@Abdkhan14
Abdkhan14 merged commit 27aa31d into abdk/scm-project-creation-disabled-tooltip Jul 15, 2026
62 checks passed
@Abdkhan14
Abdkhan14 deleted the abdk/scm-project-creation-alert-persistence branch July 15, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants