Skip to content

chore(scm-project-creation-flow): Clearing alert channel on refetch#119461

Merged
Abdkhan14 merged 6 commits into
abdk/scm-project-creation-disabled-tooltipfrom
abdk/scm-project-creation-clearing-channel
Jul 15, 2026
Merged

chore(scm-project-creation-flow): Clearing alert channel on refetch#119461
Abdkhan14 merged 6 commits into
abdk/scm-project-creation-disabled-tooltipfrom
abdk/scm-project-creation-clearing-channel

Conversation

@Abdkhan14

@Abdkhan14 Abdkhan14 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Fixes: LINEAR TICKET

The notification picker's auto-select effect was keyed on providersToIntegrations, which gets a fresh reference on every refetch (stale time zero + refetch-on-focus), so refetches re-ran it and reset the user's provider/integration and could strand a chosen channel. This guards the init with a ref so it runs once after the query first succeeds and clears the channel there; later refetches no longer rewrite a user-selected provider, integration, or channel.

Covered by new issueAlertNotificationOptions.spec.tsx tests simulating a refetch and asserting the user's selection persists, with existing specs updated.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 11, 2026
@Abdkhan14
Abdkhan14 marked this pull request as ready for review July 14, 2026 15:46
@Abdkhan14
Abdkhan14 requested a review from a team as a code owner July 14, 2026 15:46
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx Outdated
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx Outdated
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4c7127a. Configure here.

Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx
Comment thread static/app/views/projectInstall/issueAlertNotificationOptions.tsx
@Abdkhan14
Abdkhan14 requested a review from jaydgoss July 14, 2026 19:26
@Abdkhan14
Abdkhan14 merged commit c4d647b into abdk/scm-project-creation-disabled-tooltip Jul 15, 2026
81 of 87 checks passed
@Abdkhan14
Abdkhan14 deleted the abdk/scm-project-creation-clearing-channel branch July 15, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants