feat(node)!: Use function.gcp span op for Firebase functions - #22659
feat(node)!: Use function.gcp span op for Firebase functions#22659msonnb wants to merge 3 commits into
function.gcp span op for Firebase functions#22659Conversation
a754190 to
7715393
Compare
size-limit report 📦
|
334db59 to
e1785e3
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| 'sentry.source': 'route', | ||
| }, | ||
| op: 'http.request', | ||
| op: 'function.gcp', |
There was a problem hiding this comment.
Incomplete op assertions in tests
Medium Severity
This feat changes the Firebase function span op to function.gcp, including for non-HTTP triggers like onDocumentCreated, but the Firestore transaction assertions still use expect.any(String) for sentry.op and op. Those are the payloads that previously wrongly reported http.request, so the new behavior is not thoroughly asserted. Flagged because the review rules require feat coverage to assert newly added payload data thoroughly and to avoid overly relaxed assertions.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit e1785e3. Configure here.
e1785e3 to
83e7945
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2c8a0b1. Configure here.
| return startSpanManual( | ||
| { | ||
| name: `firebase.function.${triggerType}`, | ||
| op: 'http.request', |
There was a problem hiding this comment.
Wrong Firebase path updated
High Severity
The production change sets function.gcp only on the unused OTEL Firebase patch, while the public default firebaseIntegration (orchestrion) still opens spans with function.firebase. The e2e expectations for auto.firebase.orchestrion.functions were updated to function.gcp, so the intended migration does not land on the path users and those tests actually exercise.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 2c8a0b1. Configure here.
| 'sentry.source': 'route', | ||
| }, | ||
| op: 'http.request', | ||
| op: 'function.gcp', |
There was a problem hiding this comment.
Feat lacks runnable coverage
Medium Severity
This feat PR only updates test.fixme e2e cases and does not add a runnable unit, integration, or e2e test that exercises the new function.gcp op on the changed instrumentation. Per the project PR review guidelines, feat PRs need at least one integration or e2e test covering the new behavior.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 2c8a0b1. Configure here.
1 participant
Replace
http.requestwithfunction.gcpfor Firebase function triggers. The Firebase Functions wrapper instruments every v2 trigger type. A non-HTTP trigger such asonDocumentCreatedwas therefore previously reported as an HTTP operation.Part of #22446