feat(google-cloud-serverless)!: Use http.client span op for GCP HTTP requests - #22660
Merged
Conversation
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/js-3105-firebase-functions-gcp-op
branch
from
July 27, 2026 11:44
a754190 to
7715393
Compare
msonnb
force-pushed
the
ms/js-3105-gcp-http-client-op
branch
from
July 27, 2026 11:44
c3bf82c to
a7369f4
Compare
msonnb
force-pushed
the
ms/js-3105-firebase-functions-gcp-op
branch
from
July 27, 2026 12:10
7715393 to
4db7b2b
Compare
msonnb
force-pushed
the
ms/js-3105-gcp-http-client-op
branch
from
July 27, 2026 12:10
a7369f4 to
c40f643
Compare
msonnb
changed the base branch from
ms/js-3105-firebase-functions-gcp-op
to
develop
July 27, 2026 13:07
msonnb
force-pushed
the
ms/js-3105-gcp-http-client-op
branch
5 times, most recently
from
July 27, 2026 13:49
163c51e to
86a9875
Compare
…P requests The endpoint-derived suffix fragmented grouping and was unbounded for non-`googleapis.com` endpoints. Service identity moves to the `server.address` attribute; `http.request.method` is now set as well. Ref: JS-3105 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
msonnb
force-pushed
the
ms/js-3105-gcp-http-client-op
branch
from
July 28, 2026 11:11
86a9875 to
7a82c49
Compare
msonnb
marked this pull request as ready for review
July 28, 2026 11:11
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+77
to
+79
| function getServerAddress(apiEndpoint: string): string { | ||
| const url = parseStringToURLObject(apiEndpoint); | ||
| return url && !isURLObjectRelative(url) ? url.host : apiEndpoint; |
Contributor
There was a problem hiding this comment.
Bug: The code uses url.host to set the SERVER_ADDRESS attribute, which can incorrectly include the port number, violating OpenTelemetry semantic conventions.
Severity: LOW
Suggested Fix
To ensure compliance with OpenTelemetry conventions and maintain consistency within the codebase, change url.host to url.hostname. This will correctly extract only the hostname from the URL, excluding any port number.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/google-cloud-serverless/src/integrations/google-cloud-http.ts#L77-L79
Potential issue: The code uses `url.host` to populate the `SERVER_ADDRESS` OpenTelemetry
attribute. According to OpenTelemetry semantic conventions, `server.address` should only
contain the hostname, with the port stored in a separate `server.port` attribute. Using
`url.host` can include the port if a non-standard port is present in the URL. While this
is unlikely with standard Google Cloud API endpoints, it violates the specification and
is inconsistent with other parts of the codebase that correctly use `url.hostname`. This
could lead to incorrect telemetry data in environments using custom endpoints with
non-standard ports.
Did we get this right? 👍 / 👎 to inform future reviews.
msonnb
force-pushed
the
ms/js-3105-gcp-http-client-op
branch
from
July 28, 2026 13:57
006b1d0 to
a747a97
Compare
Lms24
approved these changes
Jul 28, 2026
msonnb
force-pushed
the
ms/js-3105-gcp-http-client-op
branch
from
July 28, 2026 14:43
a747a97 to
75e0096
Compare
msonnb
enabled auto-merge (squash)
July 28, 2026 14:44
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 75e0096. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
http.clientinstead ofhttp.client.<service>ingoogleCloudHttpIntegration. The service is now identified by the newserver.addressattribute. Also addedhttp.request.method.Part of #22446