Skip to content

[material_ui, cupertino_ui] Migrate macros that contain @tool #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkwingsmt wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[material_ui, cupertino_ui] Migrate macros that contain @tool #12271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84b133a
Impl
dkwingsmt Jul 22, 2026
c1db05f
Fix
dkwingsmt Jul 22, 2026
ca04778
Fix
dkwingsmt Jul 22, 2026
3ac67a2
Merge remote-tracking branch 'origin/main' into migrate-macros
dkwingsmt Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/cupertino_ui/lib/src/scrollbar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ const double _kScrollbarCrossAxisMargin = 3.0;
///
/// {@youtube 560 315 https://www.youtube.com/watch?v=DbkIQSvwnZc}
///
/// {@macro flutter.widgets.Scrollbar}
/// For more information, see [RawScrollbar].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.Scrollbar
// https://github.com/flutter/flutter/issues/189629
///
/// When dragging a [CupertinoScrollbar] thumb, the thickness and radius will
/// animate from [thickness] and [radius] to [thicknessWhileDragging] and
Expand Down
23 changes: 20 additions & 3 deletions packages/cupertino_ui/lib/src/text_field.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,13 @@ class CupertinoTextField extends StatefulWidget {
/// {@macro flutter.services.textFormatter.maxLengthEnforcement}
final MaxLengthEnforcement? maxLengthEnforcement;

/// {@macro flutter.widgets.editableText.onChanged}
/// Called when the user initiates a change to the TextField's
/// value: when they have inserted or deleted text.
///
/// For more information, see [EditableText.onChanged].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.editableText.onChanged
// https://github.com/flutter/flutter/issues/189629
final ValueChanged<String>? onChanged;

/// {@macro flutter.widgets.editableText.onEditingComplete}
Expand Down Expand Up @@ -865,10 +871,21 @@ class CupertinoTextField extends StatefulWidget {
/// {@macro flutter.services.TextInputConfiguration.enableInlinePrediction}
final bool? enableInlinePrediction;

/// {@macro flutter.widgets.editableText.contentInsertionConfiguration}
/// Configuration of handler for media content inserted via the system input
/// method.
///
/// For more information, see [EditableText.contentInsertionConfiguration].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.editableText.contentInsertionConfiguration
// https://github.com/flutter/flutter/issues/189629
final ContentInsertionConfiguration? contentInsertionConfiguration;

/// {@macro flutter.widgets.EditableText.contextMenuBuilder}
/// Builds the text selection toolbar when requested by the user.
///
/// For more information, see [EditableText.contextMenuBuilder].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.EditableText.contextMenuBuilder
// https://github.com/flutter/flutter/issues/189629
///
/// If not provided, will build a default menu based on the platform.
///
Expand Down
10 changes: 8 additions & 2 deletions packages/material_ui/lib/src/autocomplete.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ class Autocomplete<T extends Object> extends StatelessWidget {

/// The [FocusNode] that is used for the text field.
///
/// {@macro flutter.widgets.RawAutocomplete.split}
/// For more information, see [RawAutocomplete.focusNode].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.RawAutocomplete.split
// https://github.com/flutter/flutter/issues/189629
///
/// If this parameter is not null, then [textEditingController] must also be
/// non-null.
Expand Down Expand Up @@ -144,7 +147,10 @@ class Autocomplete<T extends Object> extends StatelessWidget {

/// The [TextEditingController] that is used for the text field.
///
/// {@macro flutter.widgets.RawAutocomplete.split}
/// For more information, see [RawAutocomplete.textEditingController].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.RawAutocomplete.split
// https://github.com/flutter/flutter/issues/189629
///
/// If this parameter is not null, then [focusNode] must also be non-null.
final TextEditingController? textEditingController;
Expand Down
7 changes: 6 additions & 1 deletion packages/material_ui/lib/src/reorderable_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,12 @@ class ReorderableListView extends StatefulWidget {
/// {@macro flutter.widgets.scroll_view.shrinkWrap}
final bool shrinkWrap;

/// {@macro flutter.widgets.scroll_view.anchor}
/// The relative position of the zero scroll offset.
///
/// For more information, see [ScrollView.anchor].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.scroll_view.anchor
// https://github.com/flutter/flutter/issues/189629
final double anchor;

/// {@macro flutter.rendering.RenderViewportBase.cacheExtent}
Expand Down
20 changes: 17 additions & 3 deletions packages/material_ui/lib/src/scrollbar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ const Duration _kScrollbarTimeToFade = Duration(milliseconds: 600);
///
/// {@youtube 560 315 https://www.youtube.com/watch?v=DbkIQSvwnZc}
///
/// {@macro flutter.widgets.Scrollbar}
/// For more information, see [RawScrollbar].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.Scrollbar
// https://github.com/flutter/flutter/issues/189629
///
/// Dynamically changes to a [CupertinoScrollbar], an iOS style scrollbar, by
/// default on the iOS platform.
Expand Down Expand Up @@ -111,10 +114,21 @@ class Scrollbar extends StatelessWidget {
/// {@macro flutter.widgets.Scrollbar.child}
final Widget child;

/// {@macro flutter.widgets.Scrollbar.controller}
/// The [ScrollController] used to implement Scrollbar dragging.
///
/// For more information, see [RawScrollbar.controller].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.Scrollbar.controller
// https://github.com/flutter/flutter/issues/189629
final ScrollController? controller;

/// {@macro flutter.widgets.Scrollbar.thumbVisibility}
/// Indicates that the scrollbar thumb should be visible, even when a scroll
/// is not underway.
///
/// For more information, see [RawScrollbar.thumbVisibility].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.Scrollbar.thumbVisibility
// https://github.com/flutter/flutter/issues/189629
///
/// If this property is null, then [ScrollbarThemeData.thumbVisibility] of
/// [ThemeData.scrollbarTheme] is used. If that is also null, the default value
Expand Down
17 changes: 15 additions & 2 deletions packages/material_ui/lib/src/text_field.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,13 @@ class TextField extends StatefulWidget {
/// {@macro flutter.services.textFormatter.maxLengthEnforcement}
final MaxLengthEnforcement? maxLengthEnforcement;

/// {@macro flutter.widgets.editableText.onChanged}
/// Called when the user initiates a change to the TextField's
/// value: when they have inserted or deleted text.
///
/// For more information, see [EditableText.onChanged].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.editableText.onChanged
// https://github.com/flutter/flutter/issues/189629
///
/// See also:
///
Expand Down Expand Up @@ -863,7 +869,14 @@ class TextField extends StatefulWidget {
/// {@macro flutter.services.TextInputConfiguration.enableInlinePrediction}
final bool? enableInlinePrediction;

/// {@macro flutter.widgets.editableText.contentInsertionConfiguration}
/// Configuration of handler for media content inserted via the system input
/// method.
///
/// For more information, see
/// [EditableText.contentInsertionConfiguration].
// TODO(dkwingsmt): Migrate the doc back to macro
// flutter.widgets.editableText.contentInsertionConfiguration
// https://github.com/flutter/flutter/issues/189629
final ContentInsertionConfiguration? contentInsertionConfiguration;

/// {@macro flutter.widgets.EditableText.contextMenuBuilder}
Expand Down
Loading