Skip to content

[material_ui, cupertino_ui] Migrate macros that contain @tool#12271

Open
dkwingsmt wants to merge 4 commits into
flutter:mainfrom
dkwingsmt:migrate-macros
Open

[material_ui, cupertino_ui] Migrate macros that contain @tool#12271
dkwingsmt wants to merge 4 commits into
flutter:mainfrom
dkwingsmt:migrate-macros

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

See flutter/flutter#189629.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 22, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Jul 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces several {@macro ...} documentation directives with explicit doc comments and temporary TODO notes across multiple UI components in the cupertino_ui and material_ui packages. A review comment identifies a copy-paste error in packages/material_ui/lib/src/autocomplete.dart where the documentation for textEditingController incorrectly references [RawAutocomplete.focusNode] instead of [RawAutocomplete.textEditingController].

Comment thread packages/material_ui/lib/src/autocomplete.dart Outdated
Comment thread packages/cupertino_ui/lib/src/text_field.dart Outdated
Comment thread packages/material_ui/lib/src/text_field.dart Outdated

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit

auto-submit Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12271, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: cupertino_ui p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants