Add Solid-Relay Basic Config#32
Open
dodok8 wants to merge 14 commits into
Open
Conversation
dodok8
force-pushed
the
solid-relay
branch
2 times, most recently
from
July 23, 2026 06:03
9cb81a5 to
43f65ea
Compare
dodok8
marked this pull request as ready for review
July 23, 2026 06:31
dahlia
requested changes
Jul 23, 2026
Comment on lines
+40
to
+44
| <Show when={query()?.viewer} fallback={<p>로그인되지 않았습니다.</p>}> | ||
| {(viewer) => ( | ||
| <p> | ||
| {viewer().name} | ||
| {viewer().admin ? " (관리자)" : ""} |
Member
There was a problem hiding this comment.
Okay, it's okay to write UI messages in Korean right now, but we should eventually write them in English (or properly internationalize them).
Member
There was a problem hiding this comment.
Maybe just // FIXME: i18n is enough for now, I think?
Member
Author
There was a problem hiding this comment.
I agree with @2chanhaeng's opinion, however, this pr is about Solid-Relay setting not UI Setting. I will make seperate issue and referenced it.
2chanhaeng
requested changes
Jul 23, 2026
2chanhaeng
left a comment
2chanhaeng
left a comment
Member
There was a problem hiding this comment.
Great! But I think **/__generated__/** should be included in .gitignore.
2chanhaeng
requested changes
Jul 26, 2026
Co-authored-by: Jiwon Kwon <kjiwon411@gmail.com>
Co-authored-by: Jiwon Kwon <kjiwon411@gmail.com>
Co-authored-by: Jiwon Kwon <kjiwon411@gmail.com>
Co-authored-by: Jiwon Kwon <kjiwon411@gmail.com>
Co-authored-by: Jiwon Kwon <kjiwon411@gmail.com>
Co-authored-by: Jiwon Kwon <kjiwon411@gmail.com>
Co-authored-by: Jiwon Kwon <kjiwon411@gmail.com>
2chanhaeng
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #28
This adds basic solid-relay setups to
@drfed/web. Graphql schema related files are added in.gitignore.Watchwoman is removed since it doesn't support BSER binary protocol, now it's switched back to Watchman for now.