Skip to content

Lucky-number TestDox is more detailed (arrays) [no important files changed] #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
resu-xuniL wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Lucky-number TestDox is more detailed (arrays) [no important files changed] #973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc0c0b2
Lucky-number TestDox is more detailed (arrays)
resu-xuniL May 25, 2026
a9738bc
fix indent lines
resu-xuniL May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions exercises/concept/lucky-numbers/LuckyNumbersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ public static function setUpBeforeClass(): void
* @task_id 1
*/
#[DataProvider('sumUpTestCases')]
#[TestDox('Sums up $digitsOfNumber1 and $digitsOfNumber2 to $expected')]
#[TestDox('Sums up array [$imploded_digitsOfNumber1] and array [$imploded_digitsOfNumber2] to $expected')]
public function testSumUp(
array $digitsOfNumber1,
string $imploded_digitsOfNumber1,
array $digitsOfNumber2,
string $imploded_digitsOfNumber2,
int $expected
): void {
$class = new LuckyNumbers();
Expand All @@ -31,13 +33,13 @@ public function testSumUp(
public static function sumUpTestCases()
{
return [
'both numbers same length 1' => [ [2], [7], 9 ],
'both numbers same length 2' => [ [2, 4], [5, 7], 81 ],
'both numbers same length 3' => [ [5, 3, 4], [3, 6, 2], 896 ],
'first shorter than second number' => [ [2, 4], [1, 5, 7], 181 ],
'first longer than second number' => [ [2, 2, 5], [5, 7], 282 ],
'handles overflow' => [ [9, 9, 9], [1, 0, 1], 1100 ],
'handles large numbers' => [ [9, 9, 9, 9, 9, 9], [1], 1000000 ],
'both numbers same length 1' => [ [2], "2", [7], "7", 9 ],
'both numbers same length 2' => [ [2, 4], "2, 4", [5, 7], "5, 7", 81 ],
'both numbers same length 3' => [ [5, 3, 4], "5, 3, 4", [3, 6, 2], "3, 6, 2", 896 ],
'first shorter than second number' => [ [2, 4], "2, 4", [1, 5, 7], "1, 5, 7", 181 ],
'first longer than second number' => [ [2, 2, 5], "2, 2, 5", [5, 7], "5, 7", 282 ],
'handles overflow' => [ [9, 9, 9], "9, 9, 9", [1, 0, 1], "1, 0, 1", 1100 ],
'handles large numbers' => [ [9, 9, 9, 9, 9, 9], "9, 9, 9, 9, 9, 9", [1], "1", 1000000 ],
];
}

Expand Down
Loading