Lucky-number TestDox is more detailed (arrays) [no important files changed]#973
Lucky-number TestDox is more detailed (arrays) [no important files changed]#973resu-xuniL wants to merge 2 commits into
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Thanks for pointing this out! Instead of fixing this, we'd prefer unrolling the PHPUnit DataProvider. Would you be willing to do that? Rational in short: DataProviders are a huge burden to students new to programming, as they hide the actual test call behind variables. It is very distracting from learning the type juggling when you do not see the actual literal values passed in. |
|
Why not, if I have understood the purpose correctly. |
With this add, the 'lucky-number' PHPUnit test for arrays is more verbose.
[no important files changed]