Add OS suffix support for all tool properties - #1761
Merged
Conversation
sbc100
force-pushed
the
generic-platform-attrs
branch
2 times, most recently
from
August 3, 2026 05:57
36da296 to
3ea90f9
Compare
sbc100
force-pushed
the
generic-platform-attrs
branch
3 times, most recently
from
August 3, 2026 06:24
cbf2ac8 to
702725d
Compare
Collaborator
Author
|
If you like I could split out the removal of the |
sbc100
force-pushed
the
generic-platform-attrs
branch
from
August 3, 2026 17:01
702725d to
4bdf971
Compare
kripken
approved these changes
Aug 3, 2026
We had specific hardcoded support for OS-specific URLs. This change makes that generic and allows `_windows` / `_linux` / `_mac` suffixes to work with any key. This change is really a no-op that makes way to using a windows specific activated_path for now (allowing us to use the upstream windows node archive, rather than re-packaging/hacking it in (scripts/update_node.py). See #1760. Also: - Remove support for `os: "all"`.. this is not used and doesn't seem useful (since you can just omit it). - Remove support the `unix` urls. This complexity (i.e. both unix and linux being valid suffixes) is not needed, since we can get the same behaviour by specifying `_windows` along with a generic url.
sbc100
added a commit
that referenced
this pull request
Aug 4, 2026
Instead, we can just have `window_url` and the use the default `url` as the fallback. This simplification is part of the larger change to how we do OS-specific properties. See #1761
sbc100
force-pushed
the
remove_unix_suffix
branch
from
August 4, 2026 00:52
e1bf31f to
99649d7
Compare
sbc100
force-pushed
the
generic-platform-attrs
branch
from
August 4, 2026 00:53
4bdf971 to
f4ebea7
Compare
sbc100
enabled auto-merge (squash)
August 4, 2026 00:53
sbc100
added a commit
that referenced
this pull request
Aug 4, 2026
Update the version of Node.js shipped with emsdk to the latest LTS (v24.18.1). One additional change here is that since #1761 we can now have a different activated_path for windows to other platforms. This allows us to use the upstream node archives without modifying the windows versions (they ship node.exe at the top level and not under `bin/`). Fixes: #1758
sbc100
added a commit
that referenced
this pull request
Aug 4, 2026
Since #1761 we now have os-specific keys so we don't need separate entries in these cases anymore.
sbc100
added a commit
that referenced
this pull request
Aug 5, 2026
Since #1761 we now have os-specific keys so we don't need separate entries in these cases anymore.
sbc100
added a commit
that referenced
this pull request
Aug 5, 2026
Since #1761 we now have os-specific keys so we don't need separate entries in these cases anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had specific hardcoded support for OS-specific URLs. This change makes that generic and allows
_windows/_linux/_macsuffixes to work with any key.This change is really a no-op that makes way to using a windows specific activated_path for now (allowing us to use the upstream windows node archive, rather than re-packaging/hacking it in (scripts/update_node.py). See #1760.
Also, remove support for
os: "all".. this is not used and doesn't seem useful (since you can just omit it).