Merge tools now that OS-specific keys are possible - #1768
Open
sbc100 wants to merge 1 commit into
Open
Conversation
kripken
reviewed
Aug 5, 2026
sbc100
added a commit
that referenced
this pull request
Aug 5, 2026
Rename the `uses` tool property to `deps` in `emsdk.py` and `emsdk_manifest.json`. See #1768 for an example of when this name makes more sense. We also use the term "deps" in emscripten already so this is more consistent. Update `--uses` flag description and parsing in `emsdk list` to use `--deps`.
Since #1761 we now have os-specific keys so we don't need separate entries in these cases anymore.
sbc100
commented
Aug 5, 2026
| return self.url is not None | ||
| # Tools/SDKs without an explicit 'os' filter are compatible if they specify | ||
| # a download URL *or* have dependencies. | ||
| return self.url is not None or bool(self.deps) |
Collaborator
Author
There was a problem hiding this comment.
The reason this is needed is the previously the "sdks" were listed as one-per-os, but now there is just a single one with deps and deps_linux.
Prior to this change the return statement above on line 1963 would always fire for SDKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1761 we now have os-specific keys so we don't need separate entries in these cases anymore.