fix(harmonia): calendar event titles from a relation resolve to labels, not raw FK ids#6363
Merged
Conversation
…ts referenced label The calendar pages (power MANAGE_CALENDAR and the personal my-calendar) built the event title from the raw row value - a title property that is a to-one relation rendered the FK id (e.g. every leave bar titled '7'). Both pages now resolve a relation title through the same label lookup the list columns use: the referenced controller is fetched once after the rows (the calendar paints immediately, titles refine as the map arrives), with the raw value as the fail-soft fallback for dangling FKs or a denied lookup. The EMBEDDED calendar panels (detailPanel on the master page, my-form child panels) share the same raw-title behavior and are addressed with the document-surface calendar work, where those code paths change anyway. IntentEmissionCoverageIT: the range fixture's calendar now declares title: Person (a relation) and asserts the titleLookup resolution in the generated power and personal calendar pages. Ran green locally (1/1). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
calendar: { title: <property> }naming a to-one relation rendered the raw FK id as every event's title (e.g. each leave bar titled7). The power calendar page and the personal (my) calendar page now resolve a relation title through the same label lookup the list columns use: the referenced controller is fetched once after the rows load - the calendar paints immediately and titles refine when the map arrives - with the raw value as the fail-soft fallback (dangling FK, denied lookup).A title naming a plain field is untouched.
Not in this PR
The embedded calendar panels (shared
detailPanelon the master page, the my-form child panels) share the raw-title behavior; they are addressed together with the document-surface calendar work, where those code paths change anyway.Verification
IntentEmissionCoverageIT: the range fixture's calendar now declarestitle: Person(a relation) and asserts thetitleLookupresolution in both the generated power and personal calendar pages. Ran green locally (1/1).🤖 Generated with Claude Code