feat(harmonia): embedded view: calendar child panel on the document surface (power + personal)#6364
Merged
Merged
Conversation
…r on the DOCUMENT surface too - power and personal The embedded calendar for a composition child (intent view: calendar) existed on the master layout's detail panels and the my-form child panels, but a DOCUMENT master rendered the same child as a plain table in its secondary panels - and the personal document did not render non-item children at all. The concrete case: a day-allocation calendar on a timesheet document. - perspective/document: the secondary detail panels honor def.calendar exactly like the master layout (embedded x-h-calendar; event-click edits the child, empty-day click creates one with the document FK + clicked date preset) - the shared detailPanel component already carried the whole behavior. - my-document: renders the non-item scope-inheriting children below the totals (the SAME panels the my-form renders - calendar for a view: calendar child, table otherwise), reading through the children's scoped My controllers. - embedded event titles naming a RELATION resolve to the referenced label (the raw-FK-id class, completing the standalone-calendar fix): detailPanel reuses its existing column lookups and re-renders events when maps arrive; the my-form/my-document child calendars fetch the title lookup emitted into the child config (parameterUtils), raw value as the fail-soft fallback. IntentEmissionCoverageIT: the fixture gains TicketVisit (view: calendar composition child of the personal chat Document, relation title) and asserts the power document's calendar branch, the detail registration's calendar + lookup config, and the personal document's children loading, titleLookup and panel markup. Ran green locally (1/1). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A composition child with
view: calendaralready rendered as an embedded calendar panel on the master layout and the my-form - but a Document master still rendered it as a plain table in its secondary panels, and the personal document rendered non-item children not at all. Concrete case: the day-allocation calendar on a timesheet document.def.calendarexactly like the master layout - embeddedx-h-calendar, event-click edits the child, empty-day click creates one with the document FK + the clicked date preset. The shareddetailPanelcomponent already carried the behavior; the document view only gained the branch.view: calendarchild, table otherwise), reading through the children's scoped My controllers.detailPanelreuses its existing column lookups and re-renders events when the maps arrive; the my-form/my-document child calendars fetch atitleLookupemitted into the child config, with the raw value as the fail-soft fallback.Verification
IntentEmissionCoverageIT: the fixture gainsTicketVisit- aview: calendarcomposition child of the personal chat Document with a relation title - and asserts the power document's calendar branch, the detail registration's calendar + lookup config, and the personal document's children loading,titleLookupand panel markup. Ran green locally (1/1).🤖 Generated with Claude Code