fix: make cp -r with a trailing /. copy directory contents like GNU cp - #30
Merged
Conversation
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the same bug as denoland/deno_task_shell#176.
cp -r public/. dist/createddist/publicinstead of merging the contents ofpublicintodist. The source path was resolved (normalizing the trailing/.away) before computing the destination asdist/+ basename. GNU cp uses the last component of the path as written — forpublic/.that's., so the target resolves todist/.=distitself.Changes:
calculateDestinationPathnow takes the path as specified on the command line, so a trailing/.merges directory contents into the destination (hidden files included)mv, added a guard somv public/. disterrors withrefusing to move '.' or '..'like GNU mv instead of potentially renaming over an empty destination directory