fix: refuse root as a source in cp and mv - #33
Merged
Merged
Conversation
Ports the follow-up commits on denoland/deno_task_shell#185. A source whose final path component is empty (ex. `/`) has no name to place inside the destination, so cp and mv now error instead of silently using the destination path itself. Also moves the raciness comment below the same-path guard since a string comparison isn't racy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the follow-up commits on denoland/deno_task_shell#185 (the earlier commits there were already ported in #30 and #31).
cp -r / destandmv / destnow error withthe source has no final path component. Previouslypath.basename("/")returned an empty string, socalculateDestinationPathsilently returned the destination itself — for cp that meant recursively copying the root over the destination path../..guard now runs before building operations, matching upstream (so it fires before the "target is not a directory" check).doCopyOperationmoved below the same-path guard since a string comparison isn't racy.