Skip to content

ci: remove redundant build-reactapp job from publish and test-cd #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kklldog merged 1 commit into from
Jul 26, 2026
+5 −58
Merged

ci: remove redundant build-reactapp job from publish and test-cd #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,30 +9,9 @@ on:
workflow_dispatch:

jobs:
build-reactapp:
runs-on: ubuntu-latest
defaults:
run:
working-directory: src/AgileConfig.Server.UI/react-ui-antd
strategy:
matrix:
node-version: [16.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- run: npm install
- run: npm run build
- uses: actions/upload-artifact@v4
with:
name: agileconfig-ui
path: src/AgileConfig.Server.UI/react-ui-antd/dist/
# The React admin UI is built inside the Dockerfile (ui-build stage), so there
# is no separate build-reactapp job here.
build-dotnet-push-to-hub:
needs: build-reactapp
runs-on: ubuntu-latest

steps:
Expand All @@ -48,10 +27,6 @@ jobs:
run: dotnet restore
- name: Build
run: dotnet build --configuration Release --no-restore
- uses: actions/download-artifact@v4
with:
name: agileconfig-ui
path: src/AgileConfig.Server.Apisite/wwwroot/ui
- name: Push to Docker Hub
uses: docker/build-push-action@v1
with:
Expand Down
34 changes: 3 additions & 31 deletions .github/workflows/test-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,32 +9,9 @@ on:
- 'test-*'
workflow_dispatch:
jobs:
build-reactapp:
runs-on: ubuntu-latest
defaults:
run:
working-directory: src/AgileConfig.Server.UI/react-ui-antd
strategy:
matrix:
node-version: [16.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- run: npm install
- run: npm run build

- uses: actions/upload-artifact@v4
with:
name: agileconfig-ui
path: src/AgileConfig.Server.UI/react-ui-antd/dist/

# The React admin UI is built inside the Dockerfile (ui-build stage), so there
# is no separate build-reactapp job here.
build-dotnet-push-to-hub:
needs: build-reactapp
runs-on: ubuntu-latest

steps:
Expand All @@ -51,12 +28,7 @@ jobs:
run: dotnet restore
- name: Build
run: dotnet build --configuration Release --no-restore

- uses: actions/download-artifact@v4
with:
name: agileconfig-ui
path: src/AgileConfig.Server.Apisite/wwwroot/ui


- name: Push to Docker Hub
uses: docker/build-push-action@v1
with:
Expand Down
Loading