ci: remove redundant build-reactapp job from publish and test-cd#243
Merged
Conversation
The Dockerfile now builds the React admin UI itself in a dedicated ui-build stage (added in #240), so building it again in a separate CI job and shipping the result via artifact was doing the same work twice per release — and the in-Docker build silently won anyway. Dropping the CI job leaves a single UI build path and keeps 'docker build .' reproducible outside of CI. master-ci / master-pr-ci keep their build-reactapp job: those are compile-only checks that gate frontend errors on PRs and never produce an artifact. release-xxx keeps its job too, since its zip release artifact comes from 'dotnet publish' and never goes through Docker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #240, which added a
ui-buildstage to the Dockerfile so the image builds the React admin UI itself.With that in place,
publish.ymlandtest-cd.ymlwere building the UI twice per release: once in a dedicatedbuild-reactappjob that uploadeddist/as an artifact, and again insidedocker build. The artifact was downloaded intosrc/AgileConfig.Server.Apisite/wwwroot/uibefore the Docker step, but the in-Docker build overwrites that path anyway — so the CI job's output was silently discarded.This removes the redundant job from those two workflows, leaving a single UI build path and keeping
docker build .reproducible outside of CI.Changed
publish.yml— removedbuild-reactappjob, itsneeds:edge, and thedownload-artifactsteptest-cd.yml— sameDeliberately left alone
master-ci.yml/master-pr-ci.yml— theirbuild-reactappis compile-only (npm run build, no artifact, no downstream job). It's the only CI gate that catches frontend build errors on a PR, and neither workflow builds an image, so the Dockerfile can't cover it. Kept.release-xxx.yml— besides the Docker push it produces a zip release artifact viadotnet publish, which needs the frontend inwwwroot/uiand never goes through the Dockerfile. Kept.arm32.yml/arm64.yml/mysqlconnector.yml— these run on their own long-lived branches whose Dockerfiles have noui-buildstage. They still carry their ownbuild-reactappjob, so image builds on those branches are unaffected by this PR. Those branches are 1.5–3.5 years behind master and merging it in is a large, separate piece of work — tracked separately rather than bundled here.Verification
Both files parse cleanly and each now contains exactly one job with no dangling
needs. Net −58/+5 lines.