fix: drop views instead of tables in Airflow test-schema cleanup - #120
Open
Oluwajuwon-O wants to merge 3 commits into
Open
fix: drop views instead of tables in Airflow test-schema cleanup#120Oluwajuwon-O wants to merge 3 commits into
Oluwajuwon-O wants to merge 3 commits into
Conversation
This was referenced Aug 5, 2026
information_schema.tables includes both object types; issuing only DROP VIEW fails on base tables. Clear views first, then BASE TABLEs.
Oluwajuwon-O
marked this pull request as ready for review
August 6, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Incorrect object type in Airflow test-schema cleanup
Before syncing new source data, Airflow clears the DOT tests schema via
drop_tables_in_dot_tests_schema. That function previously issuedDROP TABLE IF EXISTS ... CASCADEfor every object returned byinformation_schema.tables.Because the tests schema primarily stores dbt-generated views rather than tables, the cleanup failed to remove them. PostgreSQL then blocked later
ALTER TABLEoperations when column types changed during the data sync, causing the pipeline to fail.Resolution
DROP TABLEloop indocker/airflow/dags/run_dot_project.pywith a two-step PL/pgSQL block.information_schema.viewsto executeDROP VIEW IF EXISTS ... CASCADE.information_schema.tables(filtering fortable_type = 'BASE TABLE') to executeDROP TABLE IF EXISTS ... CASCADE.ALTER TABLElocks.In the Technical Documentation, this is addressed in Section 5.
Asana Task
Deployment Readiness*
Testing
Describe or check:
Deployment Notes
Describe or check:
Rollback Plan
Describe or check:
git revert)Reviewer Guidance / Questions*
Screenshots / Testing Evidence*
SOC 2 Change Management Checklist
./vendor/bin/pest)Provide justification if you are submitting a PR with any boxes checked other than the first.
Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.
*Optional