Skip to content

fix: drop views instead of tables in Airflow test-schema cleanup - #120

Open
Oluwajuwon-O wants to merge 3 commits into
datakind:mainfrom
Oluwajuwon-O:feature/target_schema_cleanup_fix
Open

fix: drop views instead of tables in Airflow test-schema cleanup#120
Oluwajuwon-O wants to merge 3 commits into
datakind:mainfrom
Oluwajuwon-O:feature/target_schema_cleanup_fix

Conversation

@Oluwajuwon-O

@Oluwajuwon-O Oluwajuwon-O commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Description

Incorrect object type in Airflow test-schema cleanup

Before syncing new source data, Airflow clears the DOT tests schema via drop_tables_in_dot_tests_schema. That function previously issued DROP TABLE IF EXISTS ... CASCADE for every object returned by information_schema.tables.
Because the tests schema primarily stores dbt-generated views rather than tables, the cleanup failed to remove them. PostgreSQL then blocked later ALTER TABLE operations when column types changed during the data sync, causing the pipeline to fail.

Resolution

  • Replaced the naive DROP TABLE loop in docker/airflow/dags/run_dot_project.py with a two-step PL/pgSQL block.
  • The script now explicitly queries information_schema.views to execute DROP VIEW IF EXISTS ... CASCADE.
  • It then queries information_schema.tables (filtering for table_type = 'BASE TABLE') to execute DROP TABLE IF EXISTS ... CASCADE.
  • This ensures Airflow successfully clears the dbt test schema of all object types so data syncs can proceed without ALTER TABLE locks.

In the Technical Documentation, this is addressed in Section 5.

Asana Task

Deployment Readiness*

Testing

Describe or check:

  • Created or updated unit, feature, and/or integration tests
  • Typical manual testing in the local env browser, dev pipeline, etc.

Deployment Notes

Describe or check:

  • No special deployment steps required

Rollback Plan

Describe or check:

  • Standard revert is sufficient (git revert)

Reviewer Guidance / Questions*

Screenshots / Testing Evidence*

SOC 2 Change Management Checklist

  • None of the below are true in this code
  • New roles/permissions are introduced without review and approval by the product manager
  • Hardcoded credentials, secrets, or API keys are present in this code
  • Secrets are being managed outside of the approved secrets management process (e.g., GitHub Secrets, environment variables)
  • PII or sensitive data handling is introduced or changed without being reviewed against our data classification policy
  • Sensitive data is written to logs
  • Input validation and sanitization is missing
  • An unnecessary attack surface has been introduced (e.g., unused endpoints, open ports, debug modes left enabled)
  • Common vulnerabilities have been introduced in the code (inc. any dependencies added or updated)
  • No review for common vulnerabilities has been conducted
  • Not tested in a non-production environment
  • Breaking changes to existing APIs or integrations with downstream consumers being notified
  • Performance impact has not been considered or acceptable
  • Appropriate audit logging is missing for any security-relevant actions introduced by this change
  • Log entries contain sensitive or PII data
  • All existing tests do not pass locally (./vendor/bin/pest)

Provide justification if you are submitting a PR with any boxes checked other than the first.


Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.

*Optional


@Oluwajuwon-O Oluwajuwon-O reopened this Aug 4, 2026
information_schema.tables includes both object types; issuing only
DROP VIEW fails on base tables. Clear views first, then BASE TABLEs.
@Oluwajuwon-O
Oluwajuwon-O marked this pull request as ready for review August 6, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant