Skip to content

Incremental append loads with ID-based overlap deletion - #126

Open
Oluwajuwon-O wants to merge 5 commits into
datakind:mainfrom
Oluwajuwon-O:feature/incremental_data_sync
Open

Incremental append loads with ID-based overlap deletion#126
Oluwajuwon-O wants to merge 5 commits into
datakind:mainfrom
Oluwajuwon-O:feature/incremental_data_sync

Conversation

@Oluwajuwon-O

@Oluwajuwon-O Oluwajuwon-O commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR addresses the incremental data synchronization issues described in the technical documentation:

Expensive Full-Table Replacements

Previously, the Airflow ingestion pipeline strictly used MODE = "replace". It would execute DROP TABLE ... CASCADE before loading extracted data, triggering expensive rebuilds of dependent dbt views and locking the database during every run.

Resolution

  • Load-Mode Selection: Updated save_object in docker/airflow/dags/run_dot_project.py to evaluate the presence of a date_field config property. If present, the pipeline defaults to append mode; otherwise, it falls back to replace mode.
  • ID-Based Overlap Deletion: When in append mode, the script now extracts the incoming id_field values and executes DELETE FROM ... WHERE id IN (...) on the target table before appending the new records. This prevents duplicate rows during delta loads.
  • Query Batching: The deletion logic chunks the IDs into batches of 1,000 to prevent hitting maximum parameter limits in PostgreSQL.
  • Project Configuration: Updated dot_projects.json to configure date_field and id_field properties for the new EduProject entities (students, enrollments).

In the Technical Documentation, it is addressed in Section 4
Note: This PR depends on #120 and #125.

Asana Task

Deployment Readiness*

Testing

Describe or check:

  • Created or updated unit, feature, and/or integration tests
  • Typical manual testing in the local env browser, dev pipeline, etc.

Deployment Notes

Describe or check:

  • No special deployment steps required

Rollback Plan

Describe or check:

  • Standard revert is sufficient (git revert)

Reviewer Guidance / Questions*

Screenshots / Testing Evidence*

SOC 2 Change Management Checklist

  • None of the below are true in this code
  • New roles/permissions are introduced without review and approval by the product manager
  • Hardcoded credentials, secrets, or API keys are present in this code
  • Secrets are being managed outside of the approved secrets management process (e.g., GitHub Secrets, environment variables)
  • PII or sensitive data handling is introduced or changed without being reviewed against our data classification policy
  • Sensitive data is written to logs
  • Input validation and sanitization is missing
  • An unnecessary attack surface has been introduced (e.g., unused endpoints, open ports, debug modes left enabled)
  • Common vulnerabilities have been introduced in the code (inc. any dependencies added or updated)
  • No review for common vulnerabilities has been conducted
  • Not tested in a non-production environment
  • Breaking changes to existing APIs or integrations with downstream consumers being notified
  • Performance impact has not been considered or acceptable
  • Appropriate audit logging is missing for any security-relevant actions introduced by this change
  • Log entries contain sensitive or PII data
  • All existing tests do not pass locally (./vendor/bin/pest)

Provide justification if you are submitting a PR with any boxes checked other than the first.


Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.

*Optional


information_schema.tables includes both object types; issuing only
DROP VIEW fails on base tables. Clear views first, then BASE TABLEs.
Pass source_schema through the Airflow sync path, namespace target and
test schemas as data_<conn>_<schema>, and add EduProject config pointing
at data_dot_data_education alongside ScanProject1's data_dot_data_public.
When date_field is set, save_object appends instead of replacing and
deletes overlapping target rows by id_field (chunked) before write.
@Oluwajuwon-O
Oluwajuwon-O force-pushed the feature/incremental_data_sync branch from 74b0f05 to 40e25a8 Compare August 8, 2026 07:22
@Oluwajuwon-O
Oluwajuwon-O marked this pull request as ready for review August 8, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant