Incremental append loads with ID-based overlap deletion - #126
Open
Oluwajuwon-O wants to merge 5 commits into
Open
Incremental append loads with ID-based overlap deletion#126Oluwajuwon-O wants to merge 5 commits into
Oluwajuwon-O wants to merge 5 commits into
Conversation
20 tasks
20 tasks
information_schema.tables includes both object types; issuing only DROP VIEW fails on base tables. Clear views first, then BASE TABLEs.
Pass source_schema through the Airflow sync path, namespace target and test schemas as data_<conn>_<schema>, and add EduProject config pointing at data_dot_data_education alongside ScanProject1's data_dot_data_public.
When date_field is set, save_object appends instead of replacing and deletes overlapping target rows by id_field (chunked) before write.
Oluwajuwon-O
force-pushed
the
feature/incremental_data_sync
branch
from
August 8, 2026 07:22
74b0f05 to
40e25a8
Compare
Oluwajuwon-O
marked this pull request as ready for review
August 8, 2026 07:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the incremental data synchronization issues described in the technical documentation:
Expensive Full-Table Replacements
Previously, the Airflow ingestion pipeline strictly used
MODE = "replace". It would executeDROP TABLE ... CASCADEbefore loading extracted data, triggering expensive rebuilds of dependent dbt views and locking the database during every run.Resolution
save_objectindocker/airflow/dags/run_dot_project.pyto evaluate the presence of adate_fieldconfig property. If present, the pipeline defaults toappendmode; otherwise, it falls back toreplacemode.appendmode, the script now extracts the incomingid_fieldvalues and executesDELETE FROM ... WHERE id IN (...)on the target table before appending the new records. This prevents duplicate rows during delta loads.dot_projects.jsonto configuredate_fieldandid_fieldproperties for the newEduProjectentities (students,enrollments).In the Technical Documentation, it is addressed in Section 4
Note: This PR depends on #120 and #125.
Asana Task
Deployment Readiness*
Testing
Describe or check:
Deployment Notes
Describe or check:
Rollback Plan
Describe or check:
git revert)Reviewer Guidance / Questions*
Screenshots / Testing Evidence*
SOC 2 Change Management Checklist
./vendor/bin/pest)Provide justification if you are submitting a PR with any boxes checked other than the first.
Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.
*Optional