Mongolia_Education import Fix - #2121
Open
kartik-s21 wants to merge 33 commits into
Open
Conversation
Code fix unenergy
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic table path resolution and metadata fetching in common_download_script.py to retrieve and pivot Mongolian education data. It also updates several PV map CSV files with corrected mappings and extended observation dates up to 2030, and adds place resolution to the kindergarten script in run.sh. The code review feedback highlights three key improvements: caching API responses in find_table_path to avoid redundant catalog crawls, adding timeouts to network requests to prevent hanging, and applying defensive programming checks on API responses to avoid potential runtime crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the download script and pvmappings for the import Mongolia_Education
Key Changes
PR Checklist - link