Skip to content

Use WaitGroup.Go for remaining manual Add/Done patterns#4956

Open
pietern wants to merge 1 commit intomainfrom
go1.25-waitgroup-go
Open

Use WaitGroup.Go for remaining manual Add/Done patterns#4956
pietern wants to merge 1 commit intomainfrom
go1.25-waitgroup-go

Conversation

@pietern
Copy link
Copy Markdown
Contributor

@pietern pietern commented Apr 13, 2026

Summary

  • Replace remaining wg.Add/wg.Done/go patterns with wg.Go(...) in libs/dagrun, libs/filer, and libs/sync
  • These weren't caught by the use-waitgroup-go revive rule because they call Done() inside separate functions rather than inline

Test plan

  • go test ./libs/dagrun/ ./libs/filer/ ./libs/sync/ passes

This pull request was AI-assisted by Isaac.

@github-actions
Copy link
Copy Markdown

Approval status: pending

/libs/filer/ - needs approval

Files: libs/filer/workspace_files_cache.go
Eligible: @simonfaltum, @renaudhartert-db, @hectorcast-db, @parthban-db, @tanmay-db, @Divyansh-db, @tejaskochar-db, @mihaimitrea-db, @chrisst, @rauchy

/libs/sync/ - needs approval

Files: libs/sync/sync.go
Eligible: @simonfaltum, @renaudhartert-db, @hectorcast-db, @parthban-db, @tanmay-db, @Divyansh-db, @tejaskochar-db, @mihaimitrea-db, @chrisst, @rauchy

General files (require maintainer)

Files: libs/dagrun/dagrun.go
Based on git history:

  • @denik -- recent work in libs/dagrun/

Any maintainer (@andrewnester, @anton-107, @denik, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

These call sites weren't caught by the `use-waitgroup-go` revive rule
because they call `Done()` inside separate functions rather than inline.

Co-authored-by: Isaac
@pietern pietern force-pushed the go1.25-waitgroup-go branch from ce7a67e to 5a066f0 Compare April 13, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant