Skip to content

Update PR template checklist #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Steven Gagniere (sgagniere) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update PR template checklist #3390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Checklist
Check each item below to ensure high-quality CLI development practices are followed. PR approval will not be granted until the checklist is fully reviewed.
For detailed instructions, please refer to this Confluence page: https://confluentinc.atlassian.net/wiki/spaces/AEGI/pages/3949592874/
-->
- [ ] I have added release notes above and verified that they follow the style of existing [release notes](https://docs.confluent.io/confluent-cli/current/release-notes.html).
- [ ] I have successfully built and used a custom CLI binary, without linter issues from this PR.
- [ ] I have clearly specified in the `What` section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
- [ ] I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
Expand All @@ -31,6 +32,7 @@ For detailed instructions, please refer to this Confluence page: https://conflue
- [ ] I have put checkmarks below confirming that the feature associated with this PR is enabled in:
- [ ] Confluent Cloud prod
- [ ] Confluent Cloud stag
- [ ] Confluent Cloud devel
- [ ] Confluent Platform
- [ ] Check this box if the feature is enabled for certain organizations only

Expand Down Expand Up @@ -67,6 +69,11 @@ Copy and paste the links below for easy reference.

Test & Review
-------------
- [ ] I have added or updated integration tests.
- [ ] I have added or updated unit tests.
- [ ] I have attached manual verification results or screenshots below.
- [ ] I have tested in a production environment.
- [ ] I have tested all new or updated commands and flags.
Comment on lines +72 to +76
<!-- Has this PR been tested? If so, explain **how** it was tested. Include:
- Steps taken to verify the changes.
- Links to manual verification documents, logs, or screenshots to save reviewers' time.
Expand Down