Update PR template checklist#3390
Draft
Steven Gagniere (sgagniere) wants to merge 1 commit into
Draft
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s pull request template to add additional checklist prompts around release notes, environment enablement, and testing/verification, aiming to standardize reviewer/author expectations.
Changes:
- Adds a checklist item prompting authors to include release notes matching the existing release-notes style.
- Extends the “feature enabled in” checklist to include Confluent Cloud devel.
- Adds new Test & Review checkboxes for integration/unit tests and manual verification details.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Check each item below to ensure high-quality CLI development practices are followed. PR approval will not be granted until the checklist is fully reviewed. | ||
| For detailed instructions, please refer to this Confluence page: https://confluentinc.atlassian.net/wiki/spaces/AEGI/pages/3949592874/ | ||
| --> | ||
| - [ ] I have added release notes above and verified that they follow the style of existing [release notes](https://docs.confluent.io/confluent-cli/current/release-notes.html). |
Comment on lines
+72
to
+76
| - [ ] I have added or updated integration tests. | ||
| - [ ] I have added or updated unit tests. | ||
| - [ ] I have attached manual verification results or screenshots below. | ||
| - [ ] I have tested in a production environment. | ||
| - [ ] I have tested all new or updated commands and flags. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Updating this after discussing with Cynthia Qin (@cqin-confluent).
Work in progress.
Blast Radius
References
Test & Review