chore: Move shared table-role and async-store primitives from components - #242
Draft
gethinwebster wants to merge 3 commits into
Draft
chore: Move shared table-role and async-store primitives from components#242gethinwebster wants to merge 3 commits into
gethinwebster wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 99.01% 98.07% -0.94%
==========================================
Files 44 52 +8
Lines 1314 1764 +450
Branches 341 492 +151
==========================================
+ Hits 1301 1730 +429
- Misses 13 34 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gethinwebster
marked this pull request as draft
July 29, 2026 13:43
…nents@main Pure relocation of src/table/table-role/* and src/area-chart/async-store/* (+ use-previous dep and render-hook test helper), original content and import paths (does not yet satisfy component-toolkit lint by design).
gethinwebster
force-pushed
the
dev-v3-gethinw-shared-table-role-async-store
branch
from
July 29, 2026 14:15
2ce878c to
72a67f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
table-role(grid navigation + ARIA role helpers) andasync-storeout of@cloudscape-design/componentsintocomponent-toolkitso the existing Table and the upcoming BasicTable/VirtualTable can share them.Byte-identical move (no behaviour change); adds two entrypoints:
./internal/table-roleand./internal/async-store.Related links, issue #, if available: n/a
How has this been tested?
table-role(grid-navigation,grid-navigation-processor,table-role-helper,utils) andasync-storepass in the toolkit build.@cloudscape-design/componentswas repointed locally to consume these via the new entrypoints; Table suites pass against the shared modules.(Code will be removed from components repo once this package is merged & published, WIP: https://github.com/cloudscape-design/components/pull/4846/changes)
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.