Skip to content

chore: Move shared table-role and async-store primitives from components - #242

Draft
gethinwebster wants to merge 3 commits into
mainfrom
dev-v3-gethinw-shared-table-role-async-store
Draft

chore: Move shared table-role and async-store primitives from components#242
gethinwebster wants to merge 3 commits into
mainfrom
dev-v3-gethinw-shared-table-role-async-store

Conversation

@gethinwebster

@gethinwebster gethinwebster commented Jul 29, 2026

Copy link
Copy Markdown
Member

Description

Moves table-role (grid navigation + ARIA role helpers) and async-store out of @cloudscape-design/components into component-toolkit so the existing Table and the upcoming BasicTable/VirtualTable can share them.

Byte-identical move (no behaviour change); adds two entrypoints: ./internal/table-role and ./internal/async-store.
Related links, issue #, if available: n/a

How has this been tested?

  • New/moved unit tests for table-role (grid-navigation, grid-navigation-processor, table-role-helper, utils) and async-store pass in the toolkit build.
  • Verified downstream: @cloudscape-design/components was repointed locally to consume these via the new entrypoints; Table suites pass against the shared modules.

(Code will be removed from components repo once this package is merged & published, WIP: https://github.com/cloudscape-design/components/pull/4846/changes)

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster
gethinwebster requested a review from a team as a code owner July 29, 2026 13:35
@gethinwebster
gethinwebster requested review from cansuaa and removed request for a team July 29, 2026 13:35
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.98734% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.07%. Comparing base (a7d0d07) to head (1bef45e).

Files with missing lines Patch % Lines
src/internal/table-role/grid-navigation.tsx 98.31% 3 Missing ⚠️
src/internal/table-role/utils.ts 99.01% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   99.01%   98.07%   -0.94%     
==========================================
  Files          44       52       +8     
  Lines        1314     1764     +450     
  Branches      341      492     +151     
==========================================
+ Hits         1301     1730     +429     
- Misses         13       34      +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gethinwebster
gethinwebster marked this pull request as draft July 29, 2026 13:43
@gethinwebster gethinwebster changed the title Add shared table-role and async-store primitives feat: add shared table-role and async-store primitives Jul 29, 2026
…nents@main

Pure relocation of src/table/table-role/* and src/area-chart/async-store/* (+ use-previous
dep and render-hook test helper), original content and import paths (does not yet satisfy
component-toolkit lint by design).
@gethinwebster
gethinwebster force-pushed the dev-v3-gethinw-shared-table-role-async-store branch from 2ce878c to 72a67f9 Compare July 29, 2026 14:15
@gethinwebster gethinwebster changed the title feat: add shared table-role and async-store primitives chore: Move shared table-role and async-store primitives from components Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant