refactor: consume table-role and async-store from component-toolkit - #4846
Draft
gethinwebster wants to merge 1 commit into
Draft
refactor: consume table-role and async-store from component-toolkit#4846gethinwebster wants to merge 1 commit into
gethinwebster wants to merge 1 commit into
Conversation
Delete the local src/table/table-role and src/area-chart/async-store implementations (moved to component-toolkit in cloudscape-design/component-toolkit#242) and re-export them from @cloudscape-design/component-toolkit/internal/{table-role,async-store} via thin barrels, so existing consumers are unchanged. NOTE: dry-run will fail until component-toolkit#242 merges and publishes the new entrypoints to npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consumes
table-roleandasync-storefrom@cloudscape-design/component-toolkitinstead of local copies. Deletes thesrc/table/table-roleandsrc/area-chart/async-storeimplementations (moved to the toolkit in cloudscape-design/component-toolkit#242) and re-exports them via thin barrels, so existing consumers are unchanged.This is the paired consuming change for cloudscape-design/component-toolkit#242. It is created for reference and will fail dry-run until #242 merges and publishes the new
./internal/table-roleand./internal/async-storeentrypoints to npm — until then those imports don't resolve.Related links, issue #, if available: cloudscape-design/component-toolkit#242
How has this been tested?
Not yet — blocked on the toolkit publish (see above). Once #242 is published, the existing Table and sticky-columns unit/integration suites exercise the re-exported code paths unchanged (the barrels keep the same public surface), and the
table-role/async-storetests now live in the toolkit.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.