Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/_bazel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@ jobs:
if: inputs.run_tests
run: |
bazel test --remote_cache=https://bazel:${{ secrets.BAZEL_CACHE_KEY }}@bazel-remote-cache.devprod.cloudflare.dev --config=ci ${{ inputs.extra_bazel_args }} ${{ inputs.test_target }}
- name: Run symbolized Windows repro
if: failure() && runner.os == 'Windows' && inputs.upload_binary
continue-on-error: true
run: |
bazel run --remote_cache=https://bazel:${{ secrets.BAZEL_CACHE_KEY }}@bazel-remote-cache.devprod.cloudflare.dev --config=ci ${{ inputs.extra_bazel_args }} --features=generate_pdb_file --copt=/Z7 --linkopt=/DEBUG //src/workerd/jsg:resource-test_binary
- name: Bazel coverage
if: inputs.run_coverage
run: |
Expand Down Expand Up @@ -206,11 +211,14 @@ jobs:
echo "$(Get-SizeMB $env:GITHUB_WORKSPACE)`t$env:GITHUB_WORKSPACE"

- name: Upload binary
if: inputs.upload_binary
if: always() && runner.os == 'Windows' && inputs.upload_binary
uses: actions/upload-artifact@v7
with:
name: ${{ inputs.os_name }}-${{ inputs.arch_name }}${{ inputs.suffix }}-binary
path: bazel-bin/src/workerd/server/workerd${{ runner.os == 'Windows' && '.exe' || '' }}
path: |
bazel-bin/src/workerd/server/workerd.exe
bazel-bin/src/workerd/jsg/resource-test_binary.exe
bazel-bin/src/workerd/jsg/resource-test_binary*.pdb
if-no-files-found: error
- name: Upload build statistics
if: always() && inputs.run_tests
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ jobs:
uses: ./.github/workflows/_bazel.yml
with:
image: ${{ matrix.os.image }}
# TODO: Drop before merge
upload_binary: true
os_name: ${{ matrix.os.name }}
arch_name: ${{ matrix.os.arch }}
suffix: ${{ matrix.config.suffix }}
Expand Down
6 changes: 3 additions & 3 deletions build/deps/gen/deps.MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ archive_override(
"//:patches/perfetto/0001-Don-t-attempt-to-use-rules_android.patch",
"//:patches/perfetto/0002-disable-info-level-logging-re2.patch",
],
sha256 = "60dd39e5f21800c4f61032ca9f9f73973cfc7d93db9f0d39e63ad3d8fb3740e9",
strip_prefix = "google-perfetto-25e635e",
sha256 = "af47a8eaecc7d10d868cd540dd83bfdca69ca33383b05b073f6ab3f43aac4e8a",
strip_prefix = "google-perfetto-24bdfb9",
type = "tgz",
url = "https://api.github.com/repos/google/perfetto/tarball/v56.1",
url = "https://api.github.com/repos/google/perfetto/tarball/v57.2",
)

# simdutf
Expand Down
4 changes: 2 additions & 2 deletions build/deps/v8.MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "ht

git_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")

VERSION = "15.1.206.7"
VERSION = "15.2.124.12"

INTEGRITY = "sha256-BToQQPeqVh//fw86DQYHhNVBzyfJ7f+Wlwlfz4nRBZs="
INTEGRITY = "sha256-BGe3dEsQUniLJ90HgdNGxNzoNjLNb2ZgXlEWrRk8Idc="

PATCHES = [
"0001-Allow-manually-setting-ValueDeserializer-format-vers.patch",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ diff --git a/MODULE.bazel b/MODULE.bazel
index f94686dcb5d94d0bc7c9e5113203450086e8fb36..87eb246bfe8502d5a6c667b395a26c218b81e6f5 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -14,10 +14,8 @@
@@ -14,10 +14,9 @@

"""Perfetto Bazel module configuration for bzlmod."""

Expand All @@ -18,10 +18,11 @@ index f94686dcb5d94d0bc7c9e5113203450086e8fb36..87eb246bfe8502d5a6c667b395a26c21
-)
+module(name = "perfetto")
+bazel_dep(name = "perfetto_cfg", version = "0.0.0")
+bazel_dep(name = "zlib")

bazel_dep(name = "abseil-cpp", version = "20250127.0", repo_name = "com_google_absl")
git_override(
@@ -28,97 +26,6 @@ git_override(
@@ -28,98 +26,7 @@ git_override(

bazel_dep(name = "re2", version = "2024-07-02.bcr.1")
bazel_dep(name = "bazel_skylib", version = "1.7.1")
Expand All @@ -31,6 +32,7 @@ index f94686dcb5d94d0bc7c9e5113203450086e8fb36..87eb246bfe8502d5a6c667b395a26c21
+bazel_dep(name = "protobuf", version = "33.4")
bazel_dep(name = "rules_python", version = "1.0.0")
-bazel_dep(name = "rules_android", version = "0.6.6")
bazel_dep(name = "rules_cc", version = "0.2.19")
-
-remote_android_extensions = use_extension(
- "@rules_android//bzlmod_extensions:android_extensions.bzl",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ index 0cb3e045bc46ec732956318b980e749d1847d06d..40ad805c7970cc9379e69f046205836d
* Reads raw data in various common formats to the buffer.
* Note that integer types are read in base-128 varint format, not with a
diff --git a/src/api/api.cc b/src/api/api.cc
index 9ba67d3388d8328c93309138bbf8b0954a0850aa..cbe74a9614c347753561b45b9c07598b4263bf09 100644
index 6298f80d299fa4b345a1ecf67204eba79e3f5a4c..33b9f61c8f63766cf9ebf8df09005eed9f7a9ec3 100644
--- a/src/api/api.cc
+++ b/src/api/api.cc
@@ -3731,6 +3731,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
@@ -3753,6 +3753,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
return private_->deserializer.GetWireFormatVersion();
}

Expand All @@ -52,10 +52,10 @@ index 9ba67d3388d8328c93309138bbf8b0954a0850aa..cbe74a9614c347753561b45b9c07598b
PrepareForExecutionScope api_scope{context,
RCCId::kAPI_ValueDeserializer_ReadValue};
diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
index bef656e4ed0de07435da6fb2c044171784ca2cbe..edde26bf9cc19d7a1a50ec780484cd1871602060 100644
index 0329d4e5bc201c21a14edb02cd182d9d1c83a122..98b1413ce36899243fa607a5d9aca8cef29e6106 100644
--- a/src/objects/value-serializer.h
+++ b/src/objects/value-serializer.h
@@ -221,6 +221,13 @@ class ValueDeserializer {
@@ -223,6 +223,13 @@ class ValueDeserializer {
*/
uint32_t GetWireFormatVersion() const { return version_; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ index 40ad805c7970cc9379e69f046205836dbd760373..596be18adeb3a5a81794aaa44b1d347d
* Writes out a header, which includes the format version.
*/
diff --git a/src/api/api.cc b/src/api/api.cc
index cbe74a9614c347753561b45b9c07598b4263bf09..a03b14ae35a30306fcaf0526cd5dd2f34d812c88 100644
index 33b9f61c8f63766cf9ebf8df09005eed9f7a9ec3..92a4707e8647a3bd1a03726537ba156b2d70002d 100644
--- a/src/api/api.cc
+++ b/src/api/api.cc
@@ -3603,6 +3603,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
@@ -3625,6 +3625,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)

ValueSerializer::~ValueSerializer() { delete private_; }

Expand All @@ -38,7 +38,7 @@ index cbe74a9614c347753561b45b9c07598b4263bf09..a03b14ae35a30306fcaf0526cd5dd2f3

void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
diff --git a/src/objects/value-serializer.cc b/src/objects/value-serializer.cc
index 06d1861adceae7283938849d0ca0ac9413a87119..1063a750c3b3ccb8f10127d77237880a6f8a15cf 100644
index ebac6f77e39beed8ad8f88328cc59b2b5c5eb656..95cd09d4143092d7fb64231fd837676a39b1d727 100644
--- a/src/objects/value-serializer.cc
+++ b/src/objects/value-serializer.cc
@@ -302,6 +302,7 @@ ValueSerializer::ValueSerializer(Isolate* isolate,
Expand Down Expand Up @@ -86,10 +86,10 @@ index 06d1861adceae7283938849d0ca0ac9413a87119..1063a750c3b3ccb8f10127d77237880a
}

diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
index edde26bf9cc19d7a1a50ec780484cd1871602060..1409bf5d0009f9b663892913ebc1e773921f585b 100644
index 98b1413ce36899243fa607a5d9aca8cef29e6106..4a6da3c3d024efa395820b25822a2bce1dd90188 100644
--- a/src/objects/value-serializer.h
+++ b/src/objects/value-serializer.h
@@ -54,6 +54,11 @@ class ValueSerializer {
@@ -56,6 +56,11 @@ class ValueSerializer {
ValueSerializer(const ValueSerializer&) = delete;
ValueSerializer& operator=(const ValueSerializer&) = delete;

Expand All @@ -101,7 +101,7 @@ index edde26bf9cc19d7a1a50ec780484cd1871602060..1409bf5d0009f9b663892913ebc1e773
/*
* Writes out a header, which includes the format version.
*/
@@ -182,6 +187,7 @@ class ValueSerializer {
@@ -184,6 +189,7 @@ class ValueSerializer {
bool treat_array_buffer_views_as_host_objects_ = false;
bool out_of_memory_ = false;
Zone zone_;
Expand Down
6 changes: 3 additions & 3 deletions patches/v8/0003-Allow-Windows-builds-under-Bazel.patch
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ Subject: Allow Windows builds under Bazel
Signed-off-by: James M Snell <jsnell@cloudflare.com>

diff --git a/BUILD.bazel b/BUILD.bazel
index decf32a574257963d4f30f1bc40ddc6a22c071cb..6be6167f027a77ffc28c59827eb261eeaf31ef77 100644
index 83396f2cb7acdaef099fc1e342a08b8efe635f48..1f6bd91ace173a2e758162dc39b4bfa2a663321b 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -4157,6 +4157,8 @@ filegroup(
@@ -4161,6 +4161,8 @@ filegroup(
"@v8//bazel/config:is_inline_asm_x64": ["src/heap/base/asm/x64/push_registers_asm.cc"],
"@v8//bazel/config:is_inline_asm_arm": ["src/heap/base/asm/arm/push_registers_asm.cc"],
"@v8//bazel/config:is_inline_asm_arm64": ["src/heap/base/asm/arm64/push_registers_asm.cc"],
Expand Down Expand Up @@ -88,7 +88,7 @@ index 4d002e3659aabe48faf357ba07a3f6c689a30e67..c6741a87758ec3c88807800eca9dca17
name = "is_clang",
match_any = [
diff --git a/bazel/defs.bzl b/bazel/defs.bzl
index ff118a6311e55e7de385f441ef1752ad97e4ec84..c56c0c2c3fbf3529b5dcf5d54921d4fd0b1f1b2a 100644
index 1b1234b02db103cf40451aa14f6a9e35f5a39c60..76bb755646c357f569d6d501dfc685bf27636799 100644
--- a/bazel/defs.bzl
+++ b/bazel/defs.bzl
@@ -134,6 +134,24 @@ def _default_args():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ both target and exec configurations as generator tools depend on them.
Signed-off-by: James M Snell <jsnell@cloudflare.com>

diff --git a/BUILD.bazel b/BUILD.bazel
index 6be6167f027a77ffc28c59827eb261eeaf31ef77..37a39771739b475e2a367d4f4b3b0b68aacfe6ec 100644
index 1f6bd91ace173a2e758162dc39b4bfa2a663321b..960f9b43e8c66d938d65dc8a6c3ffa5b48cefc90 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -19,6 +19,7 @@ load(
Expand All @@ -21,7 +21,7 @@ index 6be6167f027a77ffc28c59827eb261eeaf31ef77..37a39771739b475e2a367d4f4b3b0b68
)
load(":bazel/v8-non-pointer-compression.bzl", "v8_binary_non_pointer_compression")

@@ -4548,22 +4549,20 @@ filegroup(
@@ -4552,22 +4553,20 @@ filegroup(
],
)

Expand Down Expand Up @@ -50,7 +50,7 @@ index 6be6167f027a77ffc28c59827eb261eeaf31ef77..37a39771739b475e2a367d4f4b3b0b68
)

v8_mksnapshot(
@@ -4794,7 +4793,6 @@ v8_binary(
@@ -4798,7 +4797,6 @@ v8_binary(
srcs = [
"src/regexp/gen-regexp-special-case.cc",
"src/regexp/special-case.h",
Expand All @@ -59,7 +59,7 @@ index 6be6167f027a77ffc28c59827eb261eeaf31ef77..37a39771739b475e2a367d4f4b3b0b68
copts = ["-Wno-implicit-fallthrough"],
defines = [
diff --git a/bazel/defs.bzl b/bazel/defs.bzl
index c56c0c2c3fbf3529b5dcf5d54921d4fd0b1f1b2a..c395faec16e9264a066355c17daf46003937b182 100644
index 76bb755646c357f569d6d501dfc685bf27636799..709de3b6ca44124e0de5eeec57a371b2e8943866 100644
--- a/bazel/defs.bzl
+++ b/bazel/defs.bzl
@@ -356,6 +356,15 @@ def v8_library(
Expand Down Expand Up @@ -106,7 +106,7 @@ index c56c0c2c3fbf3529b5dcf5d54921d4fd0b1f1b2a..c395faec16e9264a066355c17daf4600
)

def v8_mksnapshot(name, args, suffix = ""):
@@ -661,3 +673,34 @@ def v8_build_config(name, arch):
@@ -663,3 +675,34 @@ def v8_build_config(name, arch):
outs = ["icu/" + name + ".json"],
cmd = "echo '" + build_config_content(cpu, "true") + "' > \"$@\"",
)
Expand Down
Loading
Loading